TRD rawstats from reader, pulseheight, digits and tracklets#954
Conversation
bazinski
force-pushed
the
trdrawstats
branch
from
cf9d530 to
e7ed504
Compare
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Please see my comments. Nothing significant. Thank you for your PR.
| "url": "infologger:///debug?qc" | ||
| }, | ||
| "consul": { | ||
| "url": "http://consul-test.cern.ch:8500" |
There was a problem hiding this comment.
Please remove this default consul instance. It is not used anymore. Just leave it blank.
There was a problem hiding this comment.
cool, done. The actual working json file is in my home directory on the epn. Should the current json files reside in the git repo?
There was a problem hiding this comment.
the json file in git is usually the one you use to test locally your code.
|
|
||
| /// | ||
| /// \file Noise.h | ||
| /// \author My Name |
There was a problem hiding this comment.
Could you add your name ?
There was a problem hiding this comment.
This file removed, but name fixed in the other files
| namespace o2::quality_control_modules::trd | ||
| { | ||
|
|
||
| /// \brief Example Quality Control DPL Task |
There was a problem hiding this comment.
and update the description ?
There was a problem hiding this comment.
I just removed Noise.* and updated the descriptions in the other files.
| void reset() override; | ||
|
|
||
| private: | ||
| TH1F* mHistogram = nullptr; |
There was a problem hiding this comment.
it seems that the class Noise is just the default skeleton. What is its purpose ?
There was a problem hiding this comment.
Ja it was supposed to be removed, it will be used to do the noise analysis, which is still outstanding, we have a basic one via another mechanism. Its to monitor the noise calibration.
Barthelemy
left a comment
Barthelemy
left a comment
There was a problem hiding this comment.
Thank you for your modifications.
2 participants
This adds TRD :