-
Notifications
You must be signed in to change notification settings - Fork 164
TRD rawstats from reader, pulseheight, digits and tracklets #954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| { | ||
| "qc": { | ||
| "config": { | ||
| "database": { | ||
| "implementation": "CCDB", | ||
| "host": "ccdb-test.cern.ch:8080", | ||
| "username": "not_applicable", | ||
| "password": "not_applicable", | ||
| "name": "not_applicable" | ||
| }, | ||
| "Activity": { | ||
| "number": "504419", | ||
| "type": "2", | ||
| "periodName": "", "": "Period name - e.g. LHC22c, LHC22c1b_test", | ||
| "passName": "", "": "Pass type - e.g. spass, cpass1", | ||
| "provenance": "qc", "": "Provenance - qc or qc_mc depending whether it is normal data or monte carlo data" | ||
| }, | ||
| "monitoring": { | ||
| "url": "infologger:///debug?qc" | ||
| }, | ||
| "consul": { | ||
| "url": "http://consul-test.cern.ch:8500" | ||
| }, | ||
| "conditionDB": { | ||
| "url": "ccdb-test.cern.ch:8080" | ||
| } | ||
| }, | ||
| "tasks": { | ||
| "RawDataTask": { | ||
| "active": "true", | ||
| "className": "o2::quality_control_modules::trd::RawData", | ||
| "moduleName": "QcTRD", | ||
| "detectorName": "TRD", | ||
| "cycleDurationSeconds": "1", | ||
| "maxNumberCycles": "-1", | ||
| "dataSource_comment": "no comment", | ||
| "dataSource": { | ||
| "type": "direct", | ||
| "query": "digits:TRD/DIGITS;tracklets:TRD/TRACKLETS;triggers:TRD/TRKTRGRD;rawstats:TRD/RAWSTATS" | ||
| }, | ||
| "taskParameters": { | ||
| "myOwnKey": "emptyfornow" | ||
| }, | ||
| "location": "remote", | ||
| "saveObjectsToFile":"qcrootobjects.root" | ||
| } | ||
| }, | ||
| "checks": { | ||
| "QcCheck": { | ||
| "active": "false", | ||
| "className": "o2::quality_control_modules::trd::RawDataCheck", | ||
| "moduleName": "QcTRD", | ||
| "policy": "OnAny", | ||
| "detectorName": "TRD", | ||
| "dataSource": [{ | ||
| "type": "Task", | ||
| "name": "RawDataTask", | ||
| "MOs": ["trackletsperevent"] | ||
| }] | ||
| } | ||
| } | ||
| }, | ||
| "dataSamplingPolicies": [ | ||
| ] | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| // Copyright 2019-2020 CERN and copyright holders of ALICE O2. | ||
| // See https://alice-o2.web.cern.ch/copyright for details of the copyright holders. | ||
| // All rights not expressly granted are reserved. | ||
| // | ||
| // This software is distributed under the terms of the GNU General Public | ||
| // License v3 (GPL Version 3), copied verbatim in the file "COPYING". | ||
| // | ||
| // In applying this license CERN does not waive the privileges and immunities | ||
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| /// | ||
| /// \file Noise.h | ||
| /// \author My Name | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you add your name ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This file removed, but name fixed in the other files |
||
| /// | ||
|
|
||
| #ifndef QC_MODULE_TRD_TRDNOISE_H | ||
| #define QC_MODULE_TRD_TRDNOISE_H | ||
|
|
||
| #include "QualityControl/TaskInterface.h" | ||
|
|
||
| class TH1F; | ||
|
|
||
| using namespace o2::quality_control::core; | ||
|
|
||
| namespace o2::quality_control_modules::trd | ||
| { | ||
|
|
||
| /// \brief Example Quality Control DPL Task | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. and update the description ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I just removed Noise.* and updated the descriptions in the other files. |
||
| /// \author My Name | ||
| class Noise final : public TaskInterface | ||
| { | ||
| public: | ||
| /// \brief Constructor | ||
| Noise() = default; | ||
| /// Destructor | ||
| ~Noise() override; | ||
|
|
||
| // Definition of the methods for the template method pattern | ||
| void initialize(o2::framework::InitContext& ctx) override; | ||
| void startOfActivity(Activity& activity) override; | ||
| void startOfCycle() override; | ||
| void monitorData(o2::framework::ProcessingContext& ctx) override; | ||
| void endOfCycle() override; | ||
| void endOfActivity(Activity& activity) override; | ||
| void reset() override; | ||
|
|
||
| private: | ||
| TH1F* mHistogram = nullptr; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it seems that the class Noise is just the default skeleton. What is its purpose ?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ja it was supposed to be removed, it will be used to do the noise analysis, which is still outstanding, we have a basic one via another mechanism. Its to monitor the noise calibration. |
||
| }; | ||
|
|
||
| } // namespace o2::quality_control_modules::trd | ||
|
|
||
| #endif // QC_MODULE_TRD_TRDNOISE_H | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| // Copyright 2019-2020 CERN and copyright holders of ALICE O2. | ||
| // See https://alice-o2.web.cern.ch/copyright for details of the copyright holders. | ||
| // All rights not expressly granted are reserved. | ||
| // | ||
| // This software is distributed under the terms of the GNU General Public | ||
| // License v3 (GPL Version 3), copied verbatim in the file "COPYING". | ||
| // | ||
| // In applying this license CERN does not waive the privileges and immunities | ||
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| /// | ||
| /// \file PulseHeight.h | ||
| /// \author My Name | ||
| /// | ||
|
|
||
| #ifndef QC_MODULE_TRD_TRDPULSEHEIGHT_H | ||
| #define QC_MODULE_TRD_TRDPULSEHEIGHT_H | ||
|
|
||
| #include "QualityControl/TaskInterface.h" | ||
| #include <array> | ||
|
|
||
| class TH1F; | ||
| class TH1D; | ||
| class TH2F; | ||
| class TH2D; | ||
|
|
||
| using namespace o2::quality_control::core; | ||
|
|
||
| namespace o2::quality_control_modules::trd | ||
| { | ||
|
|
||
| /// \brief Example Quality Control DPL Task | ||
| /// \author My Name | ||
| class PulseHeight final : public TaskInterface | ||
| { | ||
| public: | ||
| /// \brief Constructor | ||
| PulseHeight() = default; | ||
| /// Destructor | ||
| ~PulseHeight() override; | ||
|
|
||
| // Definition of the methods for the template method pattern | ||
| void initialize(o2::framework::InitContext& ctx) override; | ||
| void startOfActivity(Activity& activity) override; | ||
| void startOfCycle() override; | ||
| void monitorData(o2::framework::ProcessingContext& ctx) override; | ||
| void endOfCycle() override; | ||
| void endOfActivity(Activity& activity) override; | ||
| void reset() override; | ||
| void buildHistograms(); | ||
|
|
||
| private: | ||
| std::shared_ptr<TH1F> mPulseHeight = nullptr; | ||
| std::shared_ptr<TH1F> mPulseHeightScaled = nullptr; | ||
| std::shared_ptr<TH2F> mTotalPulseHeight2D = nullptr; | ||
| std::array<std::shared_ptr<TH1F>, 18> mPulseHeight2DperSM; //ph2DSM; | ||
| std::shared_ptr<TH1F> mPulseHeight2 = nullptr; | ||
| std::shared_ptr<TH1F> mPulseHeightScaled2 = nullptr; | ||
| std::shared_ptr<TH2F> mTotalPulseHeight2D2 = nullptr; | ||
| std::array<std::shared_ptr<TH1F>, 18> mPulseHeight2DperSM2; //ph2DSM; | ||
| std::pair<float, float> mDriftRegion; | ||
| std::pair<float, float> mPulseHeightPeakRegion; | ||
| std::shared_ptr<TH1F> mPulseHeightDuration; | ||
| std::shared_ptr<TH1F> mPulseHeightDuration1; | ||
| std::shared_ptr<TH1F> mPulseHeightDurationDiff; | ||
| }; | ||
|
|
||
| } // namespace o2::quality_control_modules::trd | ||
|
|
||
| #endif // QC_MODULE_TRD_TRDPULSEHEIGHT_H |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| // Copyright 2019-2020 CERN and copyright holders of ALICE O2. | ||
| // See https://alice-o2.web.cern.ch/copyright for details of the copyright holders. | ||
| // All rights not expressly granted are reserved. | ||
| // | ||
| // This software is distributed under the terms of the GNU General Public | ||
| // License v3 (GPL Version 3), copied verbatim in the file "COPYING". | ||
| // | ||
| // In applying this license CERN does not waive the privileges and immunities | ||
| // granted to it by virtue of its status as an Intergovernmental Organization | ||
| // or submit itself to any jurisdiction. | ||
|
|
||
| /// | ||
| /// \file PulseHeightCheck.h | ||
| /// \author My Name | ||
| /// | ||
|
|
||
| #ifndef QC_MODULE_TRD_TRDPULSEHEIGHTCHECK_H | ||
| #define QC_MODULE_TRD_TRDPULSEHEIGHTCHECK_H | ||
|
|
||
| #include "QualityControl/CheckInterface.h" | ||
|
|
||
| namespace o2::quality_control_modules::trd | ||
| { | ||
|
|
||
| /// \brief Example QC Check | ||
| /// \author My Name | ||
| class PulseHeightCheck : public o2::quality_control::checker::CheckInterface | ||
| { | ||
| public: | ||
| /// Default constructor | ||
| PulseHeightCheck() = default; | ||
| /// Destructor | ||
| ~PulseHeightCheck() override = default; | ||
|
|
||
| // Override interface | ||
| void configure(std::string name) override; | ||
| Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override; | ||
| void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override; | ||
| std::string getAcceptedType() override; | ||
|
|
||
| ClassDefOverride(PulseHeightCheck, 1); | ||
| }; | ||
|
|
||
| } // namespace o2::quality_control_modules::trd | ||
|
|
||
| #endif // QC_MODULE_TRD_TRDPULSEHEIGHTCHECK_H |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this default consul instance. It is not used anymore. Just leave it blank.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool, done. The actual working json file is in my home directory on the epn. Should the current json files reside in the git repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the json file in git is usually the one you use to test locally your code.