Merged
Conversation
Configure nginx proxy to communicate with Control backend which is running locally Configure Prettier (for formatting) and ESLint (for more agressive linting)
sKrzysieK
previously approved these changes
Jul 7, 2025
graduta
requested changes
Aug 4, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
While fetching session data in this way, it means that you will have to do this request at the loading of the application and stop any other request from being sent. Thus, delaying the load of the application.
I would recommend you write a fetch wrapper that always check if a token is present in current state (e.g. sessionService.js) and if not, makes the request to server to get it.
If the token is present, then use that one in the query.
You can have a look at the fetchClient.js in the framework which does exactly this for the rest of the GUIs: https://github.com/AliceO2Group/WebUi/blob/dev/Framework/Frontend/js/src/fetchClient.js
graduta
reviewed
Aug 4, 2025
Member
graduta
left a comment
graduta
left a comment
There was a problem hiding this comment.
Another comment that I have is:
- if the token is to be stored in sessionStorage of the browser, this of course it will help for example when the browser page is refreshed.
- but this will also create an issue, that is you are not tackling the case in which the token is invalid and you need to refresh the token.
Instead, if you save the token the state of the app, this will be refreshed automatically at each page entire load
This comment is open for discussion
This PR adapts the frontend to use a dropdown with the ongoing runs provided by Kafka in runs mode.
* Bump QCG
…a layout (#3084) * get object by name or id, based on a context * patch qcg to v3.15.1
…#3095) * bugfix: convert iterator into an array to be supported by safari * Bump QCG from 3.15.1 to 3.15.2
Bumps the dev-dependencies group in /Control with 1 update: [nock](https://github.com/nock/nock). Updates `nock` from 14.0.0 to 15.0.0 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v14.0.0...v15.0.0) --- updated-dependencies: - dependency-name: nock dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies ...
Bumps [winston](https://github.com/winstonjs/winston) from 3.17.0 to 3.18.0. - [Release notes](https://github.com/winstonjs/winston/releases) - [Changelog](https://github.com/winstonjs/winston/blob/master/CHANGELOG.md) - [Commits](winstonjs/winston@v3.17.0...v3.18.0) --- updated-dependencies: - dependency-name: winston dependency-version: 3.18.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: George Raduta <george.raduta@cern.ch>
…#3088) Bumps the dev-dependencies group in /InfoLogger with 1 update: [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc). Updates `eslint-plugin-jsdoc` from 60.2.0 to 60.5.0 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v60.2.0...v60.5.0) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-version: 60.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ...
) Bumps the dev-dependencies group with 3 updates in the /Framework directory: [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc), [nock](https://github.com/nock/nock) and [puppeteer](https://github.com/puppeteer/puppeteer). Updates `eslint-plugin-jsdoc` from 60.2.0 to 60.7.1 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v60.2.0...v60.7.1) Updates `nock` from 14.0.0 to 15.0.0 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v14.0.0...v15.0.0) Updates `puppeteer` from 24.22.1 to 24.23.0 - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v24.22.1...puppeteer-v24.23.0) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-version: 60.7.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: nock dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: puppeteer dependency-version: 24.23.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ...
) * Bump the dev-dependencies group across 1 directory with 3 updates Bumps the dev-dependencies group with 3 updates in the /QualityControl directory: [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc), [nock](https://github.com/nock/nock) and [puppeteer](https://github.com/puppeteer/puppeteer). Updates `eslint-plugin-jsdoc` from 60.1.1 to 60.7.1 - [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases) - [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc) - [Commits](gajus/eslint-plugin-jsdoc@v60.1.1...v60.7.1) Updates `nock` from 14.0.4 to 15.0.0 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v14.0.4...v15.0.0) Updates `puppeteer` from 24.22.0 to 24.23.0 - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v24.22.0...puppeteer-v24.23.0) --- updated-dependencies: - dependency-name: eslint-plugin-jsdoc dependency-version: 60.7.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies - dependency-name: nock dependency-version: 15.0.0 dependency-type: direct:development update-type: version-update:semver-major dependency-group: dev-dependencies - dependency-name: puppeteer dependency-version: 24.23.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: dev-dependencies ... Signed-off-by: dependabot[bot] <support@github.com> * Update docker deps * Update jsroot patch --------- Co-authored-by: George Raduta <george.raduta@cern.ch>
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4 to 5. - [Release notes](https://github.com/actions/setup-node/releases) - [Commits](actions/setup-node@v4...v5) --- updated-dependencies: - dependency-name: actions/setup-node dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ...
* updates the front-end to display lock buttons for 'Force Release ALL'&'Force Take ALL' to admin users only * updates the API endpoint to restrict those actions via the middleware * add tests for aforementioned cases Reason: * restriction is needed to prevent shifters from force taking all locks and attempting to start a run with detectors that should not be used. * in this manner the shifter has to take the locks one by one, confirming which ones are to be used with SL
Configure nginx proxy to communicate with Control backend which is running locally Configure Prettier (for formatting) and ESLint (for more agressive linting)
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…iceO2Group/WebUi into feature/CNF/OGUI-1701/session-service
Collaborator
Author
|
The wrapper for the fetch utility (and the refactor from |
sKrzysieK
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created