Fix broken release table rendering - #58
Merged
Merged
Conversation
kramdown treats <!-- ... --> as an HTML block that swallows everything up to the next blank line. The table immediately followed release-table:start with no blank line, so kramdown absorbed the whole table into that block and rendered it as literal | text instead of an HTML table (GitHub's own renderer is lenient about this and did not catch it before merge; kramdown, the site's actual renderer, is not). Verified against a local kramdown render of the live page before/after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release table in
docs/mc-software-releases/README.md(merged in #57) renders as literal|-text instead of an HTML table on the live site.Root cause: kramdown treats
<!-- ... -->as an HTML block that swallows everything up to the next blank line. The table markers I added in #57 had no blank line before the table, so kramdown absorbed the entire table into that block. GitHub's own markdown renderer is lenient about this (the PR preview looked fine), kramdown is not.Fix: blank line on both sides of
<!-- release-table:start/end -->. Verified locally with kramdown before/after (table now produces a real<table>element).