Dev - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the developer-facing setup for the project by expanding the README, making the LLM model configurable via environment variables, and changing how/where Vitest discovers tests (shifting toward a root test/ directory).
Changes:
- Make the OpenAI-compatible model name configurable via
OPENAI_MODEL. - Update Vitest test discovery globs to target root
test/patterns. - Expand README and
.env.example, and adjust.gitignoreaccordingly.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.config.ts |
Changes Vitest include globs to only look under root test/. |
README.md |
Adds comprehensive project documentation, including testing and CI command notes. |
packages/agent-core/test/tools.spec.ts |
Removes agent-core tool tests. |
packages/agent-core/test/runLoop.spec.ts |
Removes run loop tests. |
packages/agent-core/test/agent.spec.ts |
Removes agent wrapper tests. |
packages/agent-core/src/core/llm.ts |
Reads model name from OPENAI_MODEL instead of hardcoding it. |
.gitignore |
Stops ignoring packages/agent-core/test/* and starts ignoring /test/. |
.env.example |
Updates env template and introduces OPENAI_MODEL and a default base URL example. |
Suppressed comments (1)
README.md:113
- This says
/test/is gitignored and used only for local verification, but CI currently runsvitest run. With/test/ignored, CI cannot execute these tests. Clarify the CI behavior here (or adjust the repo so CI can run committed tests).
测试文件统一放在项目根目录的 `test/` 下，不放在包内。`/test/` 已加入 `.gitignore`，这些测试作为本地验证文件使用。
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| globals: true, | ||
| environment: 'node', | ||
| include: ['packages/**/test/**/*.spec.ts', 'packages/**/test/**/*.test.ts'], | ||
| include: ['test/**/*.spec.ts', 'test/**/*.test.ts'], |
| baseURL: process.env.OPENAI_API_BASE_URL, | ||
| }); | ||
|
|
||
| const llmModel = process.env.OPENAI_MODEL ?? 'deepseek-v4-flash'; |
|
|
||
| ## 常用命令 | ||
|
|
||
| 以下命令与当前 CI 保持一致： |
Comment on lines
7
to
+10
| # Optional: custom OpenAI-compatible base URL | ||
| # OPENAI_API_BASE_URL=https://api.example.com | ||
| # 留空时使用 OpenAI 默认地址；DeepSeek 可填写 https://api.deepseek.com | ||
| OPENAI_API_BASE_URL=https://api.deepseek.com | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.