fix: netease v860 codec helper should inherit v844 for correct gamerule encoding#288
Merged
Merged
Conversation
…le encoding NetEase 1.21.124 maps to vanilla v860, whose GameRulesChangedPacket serializes integer game rules with readIntLE/writeIntLE (introduced in BedrockCodecHelper_v844). The NetEase helper previously inherited from BedrockCodecHelper_v776, which fell back to the v440 implementation using VarInts.readUnsignedInt/writeUnsignedInt. This mismatch caused 'Invalid gamerule type received' when decoding any integer game rule (e.g. maxcommandchainlength), as the bytes were misinterpreted. Switch the parent to BedrockCodecHelper_v844 to align with vanilla v860/v844 behavior. The existing readLargeVarIntFlags overrides are preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NetEase 1.21.124 maps to vanilla v860, whose GameRulesChangedPacket serializes integer game rules with readIntLE/writeIntLE (introduced in BedrockCodecHelper_v844). The NetEase helper previously inherited from BedrockCodecHelper_v776, which fell back to the v440 implementation using VarInts.readUnsignedInt/writeUnsignedInt.
This mismatch caused 'Invalid gamerule type received' when decoding any integer game rule (e.g. maxcommandchainlength), as the bytes were misinterpreted.
Switch the parent to BedrockCodecHelper_v844 to align with vanilla v860/v844 behavior. The existing readLargeVarIntFlags overrides are preserved.