Preview Ideas in CMS (pt. 1/2) - #112
Open
interim17 wants to merge 1 commit into
Open
Conversation
✅ Deploy Preview for project-idea-board ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
interim17
changed the title
interim17
marked this pull request as ready for review
July 28, 2026 18:11
interim17
requested review from
meganrm and
rugeli
and removed request for
rugeli
July 28, 2026 18:11
interim17
commented
Jul 28, 2026
| authors, | ||
| date, | ||
| introduction, | ||
| isPreview, |
Contributor
Author
There was a problem hiding this comment.
I don't love these isPreview checks, and kind of wish that the gatsby components didn't need to know anything about the Decap previews, but it's probably a worthwhile tradeoff, since designing to avoid it would force bigger changes (or make previews onerous to maintain).
As far as gatsby is concerned this is just some visual noise since isPreview should never be true outside of Decap.
meganrm
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Advances #87 Advances #55
We have no customized preview for idea pages.
Solution
Now we have a much improved preview with relevant styling, and a few workarounds that need improvement over time.
I split this work into two PRs to make review simpler, this and #111 should be merged together.
In part one:
cms.jshad a typo ("idea" vs "ideas") so old preview component wasn't registering at all.Some workarounds:
isPreviewstate in the Gatsby template helps guard for cases where we can't use Gatsby components (likeLink) or consume the data layer (likeStaticQueryin child components).What we don't get: