IVSCC apfrequency: Prep 3 of x#2706
Merged
Merged
Conversation
We can just use SetDimensionLabelsFromWaveContents with cleanup for that.
The defaults for the prefix was switched.
There was a problem hiding this comment.
Pull request overview
This PR updates wave-dimension-label handling utilities and adopts the new behavior in tests and historic-data helper code, and introduces a wildcard expansion helper used by SweepFormula analysis-function parameter name resolution.
Changes:
- Replaced bespoke historic-data file label generation with
SetDimensionLabelsFromWaveContents(..., cleanup=1). - Extended
SetDimensionLabelsFromWaveContentswith acleanupoption, adjustedHasDimLabelsbehavior, and addedExpandWildcards. - Updated SweepFormula analysis-function parameter name expansion to use
ExpandWildcards, and added unit tests for the new/changed behaviors.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Packages/tests/HistoricData/UTF_HistoricDataHelpers.ipf | Switches historic-data file wave labeling to the shared utility with cleanup enabled. |
| Packages/tests/Basic/UTF_Utils_WaveHandling.ipf | Adds/extends tests for SetDimensionLabelsFromWaveContents, HasDimLabels, and ExpandWildcards. |
| Packages/MIES/MIES_Utilities_WaveHandling.ipf | Adds cleanup to SetDimensionLabelsFromWaveContents, tweaks HasDimLabels, and introduces ExpandWildcards. |
| Packages/MIES/MIES_SweepFormula_Operations.ipf | Uses ExpandWildcards to expand requested analysis-function parameter names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will merge once CI passes.