allow user to provide json dump options when using ArgSchemaParser.output - #70
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## dev #70 +/- ##
=======================================
Coverage 97.32% 97.32%
=======================================
Files 13 13
Lines 448 448
=======================================
Hits 436 436
Misses 12 12
Continue to review full report at Codecov.
|
Member
|
can you add a test? mostly because #61 might change how this looks and i'd like to make sure this functionality is maintained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A simple QoL change - I like to set the indent parameter when writing json from Python in order to get readable outputs. This change lets the user pass that and other keyword args for json.dump through ArgSchemaParser.output