fix: incorrect annotation of rewards - #74
Merged
Merged
Conversation
alexpiet
reviewed
Aug 14, 2026
arjunsridhar12345
marked this pull request as ready for review
August 19, 2026 23:07
alexpiet
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to close #73. Running on the same session as the one in #73, there are now 248 unignored trials which lines up with the metadata, and 23 auto water R that are not earned reward which should line up as seen here: https://github.com/AllenNeuralDynamics/DF-Refactoring/issues/155. I ran the
08_11_864253_auto_water_check.ipynbnotebook with an nwb generated from this branch. In addition, the warnings are gone now so maybe this fixes those alsoUpdates made:
The docstrings and comments are probably excessive and some of it is AI generated but it helped me understand the logic so I'm inclined to keep it
UPDATE: uses the trial metadata to determine type of auto reward in trial table, and then labels in acquisition remain the same