Skip to content

Comments

doc/Mirrors: fix example rsync command#352

Merged
jonathanspw merged 2 commits intoAlmaLinux:masterfrom
sbraz:mirrors_rsync
Feb 2, 2024
Merged

doc/Mirrors: fix example rsync command#352
jonathanspw merged 2 commits intoAlmaLinux:masterfrom
sbraz:mirrors_rsync

Conversation

@sbraz
Copy link

@sbraz sbraz commented Feb 1, 2024

Hi,
I discussed that in an email with @codyro and @jonathanspw. Can someone please verify my interpretation here?

R means risk, i.e. "receiver-only include" according to the manual. I believe it was a mistake because these temporary files
should be excluded, not included.

I've added a second commit to remove unnecessary trailing whitespace.

@codyro
Copy link
Member

codyro commented Feb 1, 2024

Hi Louis,

I agree with your interpretation and that the command should be updated.

I sent you an e-mail a bit back with why I believe it was setup this way initially:

I believe it was used in the past to help seed releases to mirrors prior to the public announcement.

@codyro codyro requested review from codyro and jonathanspw February 1, 2024 14:50
Louis Sautier added 2 commits February 1, 2024 16:14
R means risk, i.e. "receiver-only include" according to the manual.
Cody Robertson explained that this was probably used to help seed
eleases to mirrors prior to the public announcement.
We no longer need to include temporary files.
@sbraz
Copy link
Author

sbraz commented Feb 1, 2024

I believe it was used in the past to help seed releases to mirrors prior to the public announcement.

Oh right, I think I read the email too quickly and missed this sentence. It makes sense then :)
I've updated my commit message.

@jonathanspw
Copy link
Member

I tracked down the original commit when this was changed to 9d2bf75 but I cannot find any context as to why. I don't think it had anything to do with staging of updates.

After more reading of man pages and digging on this I have no clue why we have this and I don't see any reason not to change it - in fact I think we should change it so thank you for bringing this up!

@jonathanspw jonathanspw merged commit a1d22bf into AlmaLinux:master Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants