Skip to content

Security and deployment remediation for issues #3-#11#21

Merged
AlphaHorizon-AI merged 8 commits into
mainfrom
codex/security-hardening
Jul 25, 2026
Merged

Security and deployment remediation for issues #3-#11#21
AlphaHorizon-AI merged 8 commits into
mainfrom
codex/security-hardening

Conversation

@AlphaHorizon-AI

@AlphaHorizon-AI AlphaHorizon-AI commented Jul 25, 2026

Copy link
Copy Markdown
Owner

Summary

Implements the architecture-adjusted remediation for the security and deployment findings in issues #3?#11:

  • escapes Kaizen mandate HTML and adds stored-XSS regression tests;
  • upgrades both frontend dependency trees, pins Node 22, and adds a narrow expiring exception for the currently unpatched React Router RSC-only advisory;
  • protects Gensui and A2A outbound operations with infrastructure-admin authorization and policy-based SSRF controls that preserve private and local deployments;
  • hardens Gensui and Shogun Server containers, generated secrets, paths, non-root execution, read-only filesystems, and persistent volumes;
  • adds clean frontend, Python, Docker, CodeQL, Trivy, secret, dependency, health, UI identity, Gensui login/dashboard, and Chromium CI checks;
  • documents configuration, migration/rollback, capability limits, DNS-pinned connection behavior, and release notes.

Contributor attribution

The straightforward contributor PRs #12?#17 and #19 were reviewed and merged directly. The findings in PRs #18 and #20 are accepted; this PR supplies the architecture-adjusted replacement where Shogun needs policy-based private-network support and a fully validated headless/container profile. Release notes credit @wstlima under Security contributors.

Root causes addressed

  • User-controlled mandate Markdown crossed into dangerouslySetInnerHTML without first escaping HTML.
  • Outbound federation URLs had no authorization boundary or destination policy and followed the HTTP client's default DNS behavior.
  • Docker paths, runtime ownership, secrets, and frontend identity were insufficiently explicit or tested.
  • Dependency and deployment regressions lacked automated merge gates.

Validation

  • npm ci completed for both frontends.
  • Both npm run audit:security gates pass with only the documented, expiring GHSA-qwww-vcr4-c8h2 exception.
  • Tenshu: security lint, 7 XSS tests, TypeScript, and production build pass.
  • Gensui: security lint, TypeScript, and production build pass.
  • Ruff passes on every changed Python security/deployment boundary.
  • 39 targeted Python SSRF, authorization, configuration, redirect, logging, and Gensui routing tests pass.
  • Workflow and Dependabot YAML parse successfully.
  • Docker Compose server configuration parses successfully.

The required container jobs pass clean image builds, Trivy scans, health/UI/auth smoke tests, non-root assertions, the Gensui frontend identity check, and the Mado Chromium launch.

Issues #9 and #11 will be closed after this PR is merged to main and the resulting main revision is verified.

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread shogun/services/ssrf_guard.py Fixed
Comment thread shogun/services/ssrf_guard.py Fixed
Comment thread shogun/api/gensui_config.py Fixed
@AlphaHorizon-AI
AlphaHorizon-AI marked this pull request as ready for review July 25, 2026 08:40
@AlphaHorizon-AI
AlphaHorizon-AI merged commit fd76754 into main Jul 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants