Skip to content

885 bug after reseting testing boxsession the box has still no place for new testers anymore - #886

Merged
CapoMK25 merged 5 commits into
devfrom
885-bug-after-reseting-testing-boxsession-the-box-has-still-no-place-for-new-testers-anymore
Jul 28, 2026
Merged

885 bug after reseting testing boxsession the box has still no place for new testers anymore#886
CapoMK25 merged 5 commits into
devfrom
885-bug-after-reseting-testing-boxsession-the-box-has-still-no-place-for-new-testers-anymore

Conversation

@tickBit

@tickBit tickBit commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Brief description

In the testing box method PUT /box/reset didn't work as expected: the result was

"testersAmount": 2,
"testerAccountsClaimed": 2,
"accountClaimersIds": [],

"testerAccountsClaimed" should be 0.

Change list

  • box.service.ts:

All the necessary fields are cleared after PUT /box/reset
Also, a new test added.

Some linting changes, too...

Here's the output of Postman testing:

"createdClan_ids": [],
"testersAmount": 2,
"testerAccountsClaimed": 0,
"accountClaimersIds": []

and also

"sessionStage": "Preparing",
"testersSharedPassword": null

@codecov-alt

codecov-alt Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/box/box.service.ts 87.17% <100.00%> (+0.22%) ⬆️

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tickBit

tickBit commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

It seems, that the name of the first commit is accidentally wrong: those were not linting changes, but the actual small changes to fix the bug.

@CapoMK25 CapoMK25 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, nice job!

@github-project-automation github-project-automation Bot moved this from Backlog to Done in Altzone-Server Jul 28, 2026
@CapoMK25
CapoMK25 merged commit 1890fd9 into dev Jul 28, 2026
5 checks passed
@CapoMK25
CapoMK25 deleted the 885-bug-after-reseting-testing-boxsession-the-box-has-still-no-place-for-new-testers-anymore branch July 28, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Bug: After reseting testing box/session, the Box has still no place for new testers anymore

2 participants