convert time values to milliseconds in box/session service - #893
Merged
tickBit merged 1 commit intoAug 5, 2026
Merged
Conversation
constf03
requested review from
CapoMK25,
Iir0R,
MikhailDeriabin,
hoan301298,
psykkis and
tickBit
as code owners
August 5, 2026 12:48
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
tickBit
deleted the
889-bug-numerical-times-in-sessionstarterservicets-not-in-milliseconds
branch
August 5, 2026 12:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description
This PR converts the numerical times in SessionStarterService into milliseconds.
Because
const now = new Date().getTime();returns current date in milliseconds the other time variables must be in milliseconds too.Change list
src/box/sessionStarter/sessionStarter.service.tsandsrc/__tests__/box/SessionStarterService/start.test.tsconst timeAfterWeekandconst timeAfterMonthby 1000 to convert them into milliseconds: