Skip to content

fix: suppress Snowflake logger noise in TUI output#301

Merged
anandgupta42 merged 1 commit intoAltimateAI:mainfrom
saschabuehrle:fix/issue-300
Mar 19, 2026
Merged

fix: suppress Snowflake logger noise in TUI output#301
anandgupta42 merged 1 commit intoAltimateAI:mainfrom
saschabuehrle:fix/issue-300

Conversation

@saschabuehrle
Copy link
Contributor

@saschabuehrle saschabuehrle commented Mar 19, 2026

Bug

Fixes #300 — Snowflake SDK logger output can leak JSON log lines into the interactive terminal output, which corrupts the TUI display during spend analysis commands.

Fix

  • Keep Snowflake logging disabled with logLevel: "OFF".
  • Explicitly set additionalLogToConsole: false in snowflake.configure(...) so the SDK does not emit logger lines to the terminal stream.

Testing

  • Verified the driver-level configuration path now disables both log level and console mirroring before creating a connection.
  • Change is scoped to Snowflake connector initialization only.

Happy to address any feedback.

Greetings, saschabuehrle

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced Snowflake driver console logging suppression configuration to more effectively prevent unwanted log output in the interactive terminal environment.

Copy link

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

@github-actions
Copy link

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@coderabbitai
Copy link

coderabbitai bot commented Mar 19, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b4d0a732-2167-4a28-b9d3-72a73ac1cf10

📥 Commits

Reviewing files that changed from the base of the PR and between b25f49e and 640aa6e.

📒 Files selected for processing (1)
  • packages/drivers/src/snowflake.ts

📝 Walkthrough

Walkthrough

Updated the Snowflake SDK logging configuration to suppress console output. When snowflake.configure is available, it now passes both logLevel: "OFF" and additionalLogToConsole: false to disable all logger noise, addressing TUI output corruption from raw logger messages.

Changes

Cohort / File(s) Summary
Snowflake Logging Configuration
packages/drivers/src/snowflake.ts
Enhanced console logging suppression by adding additionalLogToConsole: false parameter alongside logLevel: "OFF". Updated accompanying comment to clarify that logging is suppressed from "interactive TUI output" rather than "stdout".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hops with glee, the logger's quiet now,
No more JSON bleeds through the TUI vow,
Snowflake whispers soft into the night,
Terminal displays clean and bright!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly identifies the main change: suppressing Snowflake logger noise in TUI output, which matches the primary objective of fixing issue #300.
Description check ✅ Passed The description covers all required sections: Bug/context (fixes #300), Fix (implementation details), and Testing (verification approach). However, it lacks CHANGELOG update and Tests/Documentation subsections.
Linked Issues check ✅ Passed The code changes (adding additionalLogToConsole: false to Snowflake configuration) directly address issue #300's core requirement to suppress logger output from the TUI.
Out of Scope Changes check ✅ Passed All changes are scoped to Snowflake connector initialization in a single file (packages/drivers/src/snowflake.ts) and directly address the linked issue #300 with no extraneous modifications.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TUI output corrupted by logger noise (Snowflake)

2 participants