fix: address multi-model code review findings for recent merges

[anandgupta42]

What does this PR do?

Addresses findings from a 6-model consensus code review (Claude, GPT 5.2 Codex, Gemini 3.1 Pro, Kimi K2.5, MiniMax M2.5, GLM-5) of the recent merges (#297, #301, #303, #305):

• Fix TUI trace dialog ignoring custom tracing.dir config — plumb config dir through DialogTraceList, getTraceViewerUrl, and openTraceInBrowser so custom trace directories work in the TUI (found by GPT 5.2 Codex)
• Fix WebFetch clearTimeout leak — move both fetch calls inside the try block so the finally clause always clears the timer, even on DNS failures or AbortError (found by Gemini 3.1 Pro)
• Fix cleanTitle empty string fallback — add "(Untitled)" as final fallback when all parsing yields empty (found by Claude, GLM-5)
• Add error logging to openTraceInBrowser — log actual error before showing toast so failures are debuggable (found by Kimi K2.5, GLM-5)
• Add altimate_change markers around HONEST_UA branding constant in webfetch.ts for upstream merge compatibility
• Update tracing docs for new /trace dialog behavior
• Update TUI docs to include /trace in slash command examples

Type of change

• Bug fix (non-breaking change which fixes an issue)

Issue for this PR

Closes #306

How did you verify your code works?

• Typecheck: 5/5 packages pass
• WebFetch tests: 8/8 pass
• Tracing persistence tests: 6/6 pass
• Branding tests: 269/269 pass
• Snowflake E2E tests: 45/45 pass (live account)
• Marker guard: clean
• Full test suite: 3776 pass (33 pre-existing failures, 243 skip)

Checklist

• My code follows the guidelines of this project
• I have performed a self-review of my code
• New and existing unit tests pass locally with my changes

🤖 Generated with Claude Code

Summary by CodeRabbit

• New Features

  • TUI trace dialog now honors custom trace directory configuration end-to-end.

• Bug Fixes

  • Fixed timeout leak in web fetch operations.
  • Improved title parsing fallback to display "(Untitled)" for traces without titles.
  • Enhanced error visibility in trace browser with detailed logging.

• Documentation

  • Updated trace and TUI documentation to reflect trace dialog behavior and slash commands.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review to trigger a review.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: b9d192c9-30c0-45f6-bf07-0f56e10b33b9

📥 Commits

Reviewing files that changed from the base of the PR and between b1e6520 and 4683ac1.

📒 Files selected for processing (6)

• .github/meta/commit.txt
• docs/docs/configure/tracing.md
• docs/docs/usage/tui.md
• packages/opencode/src/cli/cmd/tui/app.tsx
• packages/opencode/src/cli/cmd/tui/component/dialog-trace-list.tsx
• packages/opencode/src/tool/webfetch.ts

Disabled knowledge base sources:

• Jira integration is disabled

You can enable these sources in your CodeRabbit configuration.

---

📝 Walkthrough

Walkthrough

This PR addresses code review findings by fixing TUI trace directory configuration plumbing, resolving a WebFetch clearTimeout leak, improving error handling and fallback messages, and updating documentation to reflect trace dialog behavior changes and slash command updates.

Changes

Cohort / File(s)	Summary
Documentation .github/meta/commit.txt, docs/docs/configure/tracing.md, docs/docs/usage/tui.md	Updated commit record, tracing docs (trace history dialog with date grouping), and TUI docs (added /trace to slash command examples).
TUI Trace Flow packages/opencode/src/cli/cmd/tui/app.tsx, packages/opencode/src/cli/cmd/tui/component/dialog-trace-list.tsx	Threaded custom tracing.dir config through entire trace workflow: loads asynchronously on mount, passes to DialogTraceList, Tracer methods, and getTraceViewerUrl; enhanced error logging.
WebFetch Robustness packages/opencode/src/tool/webfetch.ts	Moved fetch and retry logic into try block to prevent clearTimeout leaks on DNS/AbortErrors; introduced HONEST_UA constant with merge compatibility markers.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• PR #297: Modified TUI trace flow in same files (app.tsx, dialog-trace-list.tsx, trace viewer plumbing) to implement trace history dialog selection and listing functionality.

Suggested labels

contributor

Poem

🐰 A trace through the config, no longer astray,
With tracesDir threading the right way,
No more timeouts leaking, the try block's embrace,
And "(Untitled)" shines in its proper place! ✨

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/post-merge-review-fixes

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}