Type of problem
Incomplete implementation — something's not quite right.
Describe the situation
Altinity build emits user-facing messages that reference https://clickhouse.cloud/ (a ClickHouse Inc. service). Originally noticed on a 516 AUTHENTICATION_FAILED, but git grep shows two distinct user-facing strings still leaking through.
How to reproduce the behavior
Environment
- Versions:
25.8.16.10002.altinitystable
25.3.8.10042.altinitystable
antalya-25.8
antalya-25.8
Steps
- Trigger the auth error and see the Cloud URL:
clickhouse-client --user default --password wrong -q 'SELECT 1'
Code: 516. DB::Exception: default: Authentication failed: ...
If you use ClickHouse Cloud, the password can be reset at https://clickhouse.cloud/
- Grep the source:
git grep -nI 'https://clickhouse\.cloud' -- src/
src/Access/AccessControl.cpp:660: "If you use ClickHouse Cloud, the password can be reset at https://clickhouse.cloud/"
src/Core/Settings.cpp:5919: "... Please [open a case](https://clickhouse.cloud/support) to have it set."
- Confirm in the shipped binary:
strings /usr/bin/clickhouse | grep -F 'https://clickhouse.cloud'
Expected behavior
No https://clickhouse.cloud/ references in user-facing strings of the Altinity build.
Actual behavior
| File |
Line |
What leaks |
src/Access/AccessControl.cpp |
660 |
Cloud password-reset URL appended to every AUTHENTICATION_FAILED (516) message |
src/Core/Settings.cpp |
5919 |
compatibility setting description points to https://clickhouse.cloud/support |
Out of scope (do not change):
src/Client/ConnectionParameters.cpp:36 — functional .clickhouse.cloud host suffix detection.
- Occurrences under
docs/.
tests/queries/0_stateless/03362_basic_auth_interactive_not_with_authorization_never.reference — will need to be updated alongside the fix.
Additional context
Suggested follow-ups
- Patch the two strings in the Altinity fork.
- Update
tests/queries/0_stateless/03362_*.reference to match the new message.
- Add a regression check in
clickhouse-regression (suite version) that fails if https://clickhouse.cloud appears in the binary.
Type of problem
Incomplete implementation — something's not quite right.
Describe the situation
Altinity build emits user-facing messages that reference
https://clickhouse.cloud/(a ClickHouse Inc. service). Originally noticed on a516 AUTHENTICATION_FAILED, butgit grepshows two distinct user-facing strings still leaking through.How to reproduce the behavior
Environment
25.8.16.10002.altinitystable25.3.8.10042.altinitystableantalya-25.8antalya-25.8Steps
clickhouse-client --user default --password wrong -q 'SELECT 1'git grep -nI 'https://clickhouse\.cloud' -- src/Expected behavior
No
https://clickhouse.cloud/references in user-facing strings of the Altinity build.Actual behavior
src/Access/AccessControl.cppAUTHENTICATION_FAILED(516) messagesrc/Core/Settings.cppcompatibilitysetting description points tohttps://clickhouse.cloud/supportOut of scope (do not change):
src/Client/ConnectionParameters.cpp:36— functional.clickhouse.cloudhost suffix detection.docs/.tests/queries/0_stateless/03362_basic_auth_interactive_not_with_authorization_never.reference— will need to be updated alongside the fix.Additional context
Suggested follow-ups
tests/queries/0_stateless/03362_*.referenceto match the new message.clickhouse-regression(suiteversion) that fails ifhttps://clickhouse.cloudappears in the binary.