Skip to content

25.8.16 Stable Backport of #90059: Unblock ttl part drops for cold volumes#1363

Merged
MyroTk merged 1 commit intoreleases/25.8.16from
backports/25.8.15/90059
Feb 6, 2026
Merged

25.8.16 Stable Backport of #90059: Unblock ttl part drops for cold volumes#1363
MyroTk merged 1 commit intoreleases/25.8.16from
backports/25.8.15/90059

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Feb 3, 2026

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Split part ranges by volume characteristics to enable TTL drop merges for cold volumes. After this patch, parts with a max TTL < now will be removed from cold storage. The algorithm will schedule only single part drops. (ClickHouse#90059 by @Michicosun)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Workflow [PR], commit [17cd534]

@DimensionWieldr

This comment was marked as outdated.

@DimensionWieldr DimensionWieldr added the verified Verified by QA label Feb 5, 2026
…merges_in_cold_volumes

Unblock ttl part drops for cold volumes
@zvonand zvonand force-pushed the backports/25.8.15/90059 branch from 016b43a to 17cd534 Compare February 5, 2026 08:31
@zvonand zvonand changed the base branch from releases/25.8.15 to releases/25.8.16 February 5, 2026 08:32
@zvonand
Copy link
Collaborator Author

zvonand commented Feb 5, 2026

@DimensionWieldr I rebased this PR onto 25.8.16 branch -- pls re-verify it in a couple of hours (CI runs anew)

@zvonand zvonand changed the title 25.8.15 Stable Backport of #90059: Unblock ttl part drops for cold volumes 25.8.16 Stable Backport of #90059: Unblock ttl part drops for cold volumes Feb 5, 2026
@zvonand zvonand added 25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable and removed verified Verified by QA 25.8.15 25.8.15.10001 labels Feb 5, 2026
@zvonand
Copy link
Collaborator Author

zvonand commented Feb 5, 2026

03321_clickhouse_local_initialization_not_too_slow_even_under_sanitizers, test_dirty_pages_force_purge are both known and not important now, but @CarlosFelipeOR and @DimensionWieldr would give a better explanation here

@DimensionWieldr
Copy link
Collaborator

DimensionWieldr commented Feb 5, 2026

CI Failure Analysis (Post-Rebase to 25.8.16)


1. Regression Tests (aggregate_functions_1) - Pre-existing Failure

Failure: /aggregate functions/part 1/uniqTheta (both aarch64 and release)

Evidence these are pre-existing on base branch (releases/25.8.16):

  • MasterCI #21704306488 (Feb 05): AggregateFunctions (1) = failure
  • MasterCI #21640745419 (Feb 03): AggregateFunctions (1) = failure

Root cause: uniqTheta was updated in upstream.

Verdict: Pre-existing failure on base branch. Unrelated to PR changes.


2. Regression Tests (S3 suites) - Pre-existing Failures

Failures:

  • s3_aws_s3_2 (aarch64 and release)
  • s3_azure_2 (aarch64 and release)
  • s3_minio_2 (aarch64 and release)

Evidence these are pre-existing on base branch:

Root cause: Zero copy replication tests failing - tracked in Altinity/clickhouse-regression#93

Verdict: Pre-existing failures on base branch. Unrelated to PR changes.


3. Infrastructure Failures (GitHub Actions Job Failures)

Failures:

  • Integration tests (amd_asan, old analyzer, 1/6) - Job failed at 47m6s
  • Integration tests (amd_asan, old analyzer, 2/6) - Job failed at 2h9m26s
  • Stateless tests (amd_msan, parallel, 2/2) - Job failed at 47m6s

Evidence: These jobs failed at the GitHub Actions level without producing test results in the praktika report. The two 47m6s failures occurred at the same timestamp, suggesting infrastructure termination rather than test failures.

Verdict: CI infrastructure failures. Unrelated to PR changes.


4. Stateless Tests (amd_tsan, sequential, 2/2)

Failure: 03321_clickhouse_local_initialization_not_too_slow_even_under_sanitizers

What the test does: Measures if clickhouse-local can start 10 times in 10 seconds under sanitizers.

Code path analysis: The PR modifies merge selector and predicate code for TTL/cold volumes. This test only measures client startup speed - zero code path overlap with PR changes.

Verdict: Timing-sensitive performance test with no code path overlap. Unrelated to PR changes.


5. Integration Tests - test_dirty_pages_force_purge

Failures:

  • Integration tests (amd_binary, 2/5) - fail: 1, passed: 1011
  • Integration tests (arm_binary, distributed plan, 2/4) - fail: 1, passed: 988

What the test does: Tests jemalloc memory dirty page purge behavior via MemoryAllocatorPurge events.

Root cause: Test fails due to lower kernel version on CI runners.

Verdict: Infrastructure/environment issue. Unrelated to PR changes.


6. Regression Tests (iceberg_2)

Failure: data_types_check_where assertion failed - expected '0' but got empty result

Base branch status:

Code path analysis:

  • PR modifies: TTL merge selector, merge predicates for parts on cold volumes
  • Test uses: Iceberg table engine data type handling with WHERE clauses
  • No code path overlap - PR does not modify Iceberg engine or query execution

Verdict: Test passed on base branch but failed on PR. Code path analysis shows no overlap with PR changes. Likely flaky.


Summary

Test Category Failure Type Related to PR?
Regression aggregate_functions_1 (2 jobs) Pre-existing (uniqTheta upstream change) No
Regression S3 (6 jobs) Pre-existing (zero copy replication) No
ASAN/MSAN jobs (3 jobs) Infrastructure failure No
03321_clickhouse_local_init... No code path overlap No
test_dirty_pages_force_purge (2 jobs) Lower kernel version on runners No
Regression iceberg_2 No code path overlap No

Verdict: All failures are unrelated to the PR changes.

@DimensionWieldr DimensionWieldr added the verified Verified by QA label Feb 5, 2026
@MyroTk MyroTk merged commit dba4ab3 into releases/25.8.16 Feb 6, 2026
410 of 438 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

25.8.16 25.8.16 Stable 25.8.16.10001 25.8.16.10001 Stable verified Verified by QA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments