25.8.16 Stable Backport of #90059: Unblock ttl part drops for cold volumes#1363
25.8.16 Stable Backport of #90059: Unblock ttl part drops for cold volumes#1363MyroTk merged 1 commit intoreleases/25.8.16from
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
…merges_in_cold_volumes Unblock ttl part drops for cold volumes
016b43a to
17cd534
Compare
|
@DimensionWieldr I rebased this PR onto 25.8.16 branch -- pls re-verify it in a couple of hours (CI runs anew) |
|
|
CI Failure Analysis (Post-Rebase to 25.8.16)1. Regression Tests (aggregate_functions_1) - Pre-existing FailureFailure: Evidence these are pre-existing on base branch (
Root cause: Verdict: Pre-existing failure on base branch. Unrelated to PR changes. 2. Regression Tests (S3 suites) - Pre-existing FailuresFailures:
Evidence these are pre-existing on base branch:
Root cause: Zero copy replication tests failing - tracked in Altinity/clickhouse-regression#93 Verdict: Pre-existing failures on base branch. Unrelated to PR changes. 3. Infrastructure Failures (GitHub Actions Job Failures)Failures:
Evidence: These jobs failed at the GitHub Actions level without producing test results in the praktika report. The two 47m6s failures occurred at the same timestamp, suggesting infrastructure termination rather than test failures. Verdict: CI infrastructure failures. Unrelated to PR changes. 4. Stateless Tests (amd_tsan, sequential, 2/2)Failure: What the test does: Measures if Code path analysis: The PR modifies merge selector and predicate code for TTL/cold volumes. This test only measures client startup speed - zero code path overlap with PR changes. Verdict: Timing-sensitive performance test with no code path overlap. Unrelated to PR changes. 5. Integration Tests -
|
| Test Category | Failure Type | Related to PR? |
|---|---|---|
| Regression aggregate_functions_1 (2 jobs) | Pre-existing (uniqTheta upstream change) |
No |
| Regression S3 (6 jobs) | Pre-existing (zero copy replication) | No |
| ASAN/MSAN jobs (3 jobs) | Infrastructure failure | No |
03321_clickhouse_local_init... |
No code path overlap | No |
test_dirty_pages_force_purge (2 jobs) |
Lower kernel version on runners | No |
| Regression iceberg_2 | No code path overlap | No |
Verdict: All failures are unrelated to the PR changes.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Split part ranges by volume characteristics to enable TTL drop merges for cold volumes. After this patch, parts with a max TTL < now will be removed from cold storage. The algorithm will schedule only single part drops. (ClickHouse#90059 by @Michicosun)
CI/CD Options
Exclude tests:
Regression jobs to run: