Skip to content

[Before forward-ports] Antalya 26.3: patch for SettingsChangesHistory#1653

Merged
zvonand merged 3 commits intoantalya-26.3from
fix/antalya-26.3/fix-settingschangeshistory
Apr 19, 2026
Merged

[Before forward-ports] Antalya 26.3: patch for SettingsChangesHistory#1653
zvonand merged 3 commits intoantalya-26.3from
fix/antalya-26.3/fix-settingschangeshistory

Conversation

@zvonand
Copy link
Copy Markdown
Collaborator

@zvonand zvonand commented Apr 15, 2026

When porting to future Antalya versions:

  • generate .tsv file containing settings values in latest Antalya release (more details in comments in tests/queries/0_stateless/02995_new_settings_history.sh), change the version number in test accordingly;
  • add new version section for the next release in src/Core/SettingsChangesHistory.cpp;

When cherry-pinking, do cherry-pick -n avoid picking:

  • ...tsv file: it needs to be re-generated
  • SettingsChangesHistory.cpp: instead, take Antalya-related sections from previous Antalya release's SettingsChangesHistory.cpp and manually add them to current file. comment all lines with Antalya-specific settings.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • S3 Export (2h)
  • Swarms (30m)
  • Tiered Storage (2h)

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 15, 2026

Workflow [PR], commit [9633607]

@ianton-ru
Copy link
Copy Markdown

test_backward_compatibility/test_convert_ordinary.py::test_convert_ordinary_to_atomic broken, fix in #1646 - 24b139f

@ianton-ru
Copy link
Copy Markdown

Regression tests failed because test unmerged features, ignore it.

normalize_function_names 1
number_of_mutations_to_delay 0
number_of_mutations_to_throw 0
object_storage_cluster
Copy link
Copy Markdown

@ianton-ru ianton-ru Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this line correct before feature with object_storage_cluster merged? (Same for all Antalya-only features)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess so. A setting in CH is compared against this file, not the other way around. So it is fine to have some unincluded extra.

@zvonand zvonand added the port-antalya PRs to be ported to all new Antalya releases label Apr 19, 2026
@zvonand zvonand merged commit 1ef14ef into antalya-26.3 Apr 19, 2026
361 of 435 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

antalya antalya-26.3 port-antalya PRs to be ported to all new Antalya releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants