Change export_merge_tree_partition_manifest_ttl to 86400#1692
Change export_merge_tree_partition_manifest_ttl to 86400#1692zvonand merged 2 commits intoantalya-26.1from
Conversation
Updated the manifest TTL for export merge tree partitions from 180 seconds to 86400 seconds.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f85d330323
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Maximum number of retries for exporting a merge tree part in an export partition task | ||
| )", 0) \ | ||
| DECLARE(UInt64, export_merge_tree_partition_manifest_ttl, 180, R"( | ||
| DECLARE(UInt64, export_merge_tree_partition_manifest_ttl, 86400, R"( |
There was a problem hiding this comment.
This changes the default in Settings.cpp but does not add a corresponding entry in src/Core/SettingsChangesHistory.cpp, so SET compatibility = '<older version>' will not roll export_merge_tree_partition_manifest_ttl back to 180 even though applyCompatibilitySetting only reverts values recorded in that history map (Settings.cpp around lines 8026-8050). That makes this default change unexpectedly backward-incompatible for clusters relying on compatibility mode after upgrade.
Useful? React with 👍 / 👎.
3 participants
Updated the manifest TTL for export merge tree partitions from 180 seconds to 86400 seconds.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Change the default value of
export_merge_tree_partition_manifest_ttlfrom 180 seconds to 86400 (a day). This gives visibility over completed export partitions on real usage scenarios.Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: