Do not read metadata.json on initial host with remote initiator#1760
Do not read metadata.json on initial host with remote initiator#1760ianton-ru wants to merge 1 commit intoantalya-26.3from
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 263b9e0dfb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (query_context->getSettingsRef()[Setting::object_storage_remote_initiator]) | ||
| return; |
There was a problem hiding this comment.
Refresh metadata even when using remote initiator
Returning early when object_storage_remote_initiator is enabled skips all dynamic metadata refresh on the initiating node, so its in-memory schema/state can become stale after Iceberg/DeltaLake snapshot changes. The initiator still performs query analysis and builds storage_snapshot locally (e.g., before rewriting to remote(...)), so a query that references newly added columns can fail at analysis with unknown-column errors even though the remote node has up-to-date metadata. Previously this path always called configuration->update, so this is a regression for sessions that keep object_storage_remote_initiator=1 across evolving lakehouse tables.
Useful? React with 👍 / 👎.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Do not read metadata.json on initial host with remote initiator
Documentation entry for user-facing changes
With remote initiator for Iceberg table source node reads metadata.json but does not use.
This PR turns off this reading.
CI/CD Options
Exclude tests:
Regression jobs to run: