Antalya 26.3 Backport of #101548 - Fix Iceberg write retry loop stuck on explicit metadata file path

[mkmkme]

Changelog category (leave one):

• Bug Fix (user-visible misbehavior in an official stable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix Iceberg INSERT retry loop failing when the table was created with iceberg_metadata_file_path and the target metadata version already exists (ClickHouse#101548 by @groeneai)

Documentation entry for user-facing changes

...

CI/CD Options

Exclude tests:

• Fast test
• Integration Tests
• Stateless tests
• Stateful tests
• Performance tests
• All with ASAN
• All with TSAN
• All with MSAN
• All with UBSAN
• All with Coverage
• All with Aarch64
• All Regression
• Disable CI Cache

Regression jobs to run:

• Fast suites (mostly <1h)
• Aggregate Functions (2h)
• Alter (1.5h)
• Benchmark (30m)
• ClickHouse Keeper (1h)
• Iceberg (2h)
• LDAP (1h)
• Parquet (1.5h)
• RBAC (1.5h)
• SSL Server (1h)
• S3 (2h)
• S3 Export (2h)
• Swarms (30m)
• Tiered Storage (2h)

[github-actions]

Workflow [PR], commit [f054f55]

[alsugiliazova]

Verification: PR #1771

PR-added test — GREEN

04079_iceberg_write_retry_explicit_metadata — 3/3 OK across all stateless jobs that picked it up:

Job	Status
Stateless tests (amd_asan, distributed plan, parallel, 4/4)	OK
Stateless tests (amd_debug, parallel)	OK
Stateless tests (arm_binary, parallel)	OK
Fast test	SKIPPED (expected, Tags: no-fasttest)

The new retry-loop fix has clean positive coverage.

Note: CI for this head ran with reduced fan-out (PR test workflow shows only 6 success / 90 skipped). The test only ran on 3 of the usual ~6 stateless jobs because the other jobs were skipped at workflow level, not because the test failed.

CI overview (head commit)

• PR test workflow: 6 success / 90 skipped / 2 failure
• Regression workflow: 28 success / 66 skipped / 8 failure (chronic baseline)
• One pending action_required job (queue/auth)

PR test-workflow failures

Check	Verdict
Stateless tests (arm_asan, targeted) — 01171_mv_select_insert_isolation_long	Pre-existing flake, 13 fails / 10 PRs in last 30 days. Unrelated to the Iceberg write path.
Stateless tests (amd_asan, distributed plan, parallel, 1/4)	Job-level error, 0 test FAIL rows in DB. Infra failure on shard 1/4 (the test under question was run by shard 4/4 and passed).

Regression-workflow failures (chronic baseline on antalya-26.3)

Suite	Fails
Swarms (Aarch64 + Release)	227
Parquet (Aarch64 + Release)	34
S3Export partition (Aarch64 + Release)	20
S3Export part (Aarch64 + Release)	14

Identical fingerprint to sibling antalya-26.3 PRs (1770, 1769, 1767, 1762, 1759, …). No new failure modes.

Caveat — partial frontport

This PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Some regression suites still rely on settings/CLI args not yet wired in this base. A final re-verify is recommended once the rest of the bundle lands.

Verdict

Safe to merge.

• PR’s new test 04079_iceberg_write_retry_explicit_metadata passes 100% (3/3 stateless runs).
• Only one test-level FAIL (01171_mv_select_insert_isolation_long) — well-known pre-existing flake.
• The other 9 red checks are job-level/infra errors and the recurring antalya-26.3 chronic regression baseline.

[alsugiliazova]

Audit: PR #1771 — Antalya 26.3 Backport of #101548 — Fix Iceberg write retry loop stuck on explicit metadata file path

AI audit note: This review comment was generated by AI (Cursor agent, audit-review skill).

Confirmed defects

No confirmed defects in reviewed scope.