Antalya 26.3 Backport of #101278, #102337 - Multiple Iceberg fixes#1773
Antalya 26.3 Backport of #101278, #102337 - Multiple Iceberg fixes#1773mkmkme wants to merge 2 commits into
Conversation
Fix Iceberg `ALTER TABLE UPDATE` exception on partitioned tables.
Fix Iceberg mutation crash: unwrap LowCardinality/Nullable before Avro serialization
Verification: PR #1773PR-added tests — all GREEN2 tests × 6 stateless jobs each = 12 OK runs, 0 failures. (1 SKIPPED per test in Fast test, as expected.)
Jobs covered: Both new Iceberg-mutation code paths have clean positive coverage. CI overview (head commit)
PR test-workflow failures
Regression-workflow failures (chronic baseline on
|
| Suite | Fails |
|---|---|
| Swarms (Aarch64 + Release) | 227 |
| Parquet (Aarch64 + Release) | 34 |
S3Export partition (Aarch64 + Release) |
20 |
S3Export part (Aarch64 + Release) |
14 |
Same fingerprint as sibling antalya-26.3 PRs (1772, 1771, 1770, 1769, 1767, …). No new failure modes.
Caveat — partial frontport
This PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Final re-verify recommended once the rest of the bundle lands.
Verdict
Safe to merge.
- Both PR-added tests pass 100% (12/12 stateless runs) for empty-partition-block and LowCardinality UPDATE paths.
- All test-level failures are well-known pre-existing flakes (
test_sync_replica,03443_shared_storage_snapshots) or the recurringtest_s3_clustershard-3/6 cascade. - Regression failures match the chronic
antalya-26.3baseline.
Audit: PR #1773 — Antalya 26.3 Backport of #101278 + #102337 — Multiple Iceberg fixesAI audit note: This review comment was generated by AI (Cursor agent, audit-review skill). Confirmed defectsNo confirmed defects in reviewed scope. |
Note for reviewer
I wanted to apply only 102337 initially, but it caused conflicts due to missing changes from 101278. Therefore I decided to apply both of them at once.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix
Logical error: 'partitions_count > 0'exception when performing consecutiveALTER TABLE UPDATEon a partitioned Iceberg table (ClickHouse#101278 by @Desel72).Fix crash in
IcebergLocalALTER TABLE ... UPDATEwhen using Avro format, caused byLowCardinality/Nullablewrapper types not being unwrapped before serialization (ClickHouse#102337 by @Desel72).Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: