Antalya 26.3 Backport of #100283 - Validate Iceberg metadata file path for null bytes#1775
Open
mkmkme wants to merge 1 commit into
Open
Antalya 26.3 Backport of #100283 - Validate Iceberg metadata file path for null bytes#1775mkmkme wants to merge 1 commit into
mkmkme wants to merge 1 commit into
Conversation
…-byte-in-path Validate Iceberg metadata file path for null bytes
Member
Verification: PR #1775PR-relevant test — GREEN
The tightened null-byte assertions all pass — the new CI overview (head commit)
PR test-workflow failures
Regression-workflow failures (chronic baseline on
|
| Suite | Fails |
|---|---|
| Swarms (Aarch64 + Release) | 227 |
| Parquet (Aarch64 + Release) | 34 |
S3Export partition (Aarch64 + Release) |
20 |
S3Export part (Aarch64 + Release) |
16 |
Same fingerprint as sibling antalya-26.3 PRs (1773, 1772, 1771, 1770, 1769, …). No new failure modes.
Caveat — partial frontport
This PR lands on antalya-26.3 while companion features from antalya-26.1 are still being frontported in parallel. Final re-verify recommended once the rest of the bundle lands.
Verdict
Safe to merge.
- PR diff is a 2-line defensive guard; the existing security test (with updated assertions) passes 100% (3/3) across all integration jobs.
- All other failing checks are pre-existing infra flakes (Nessie integration, stress shutdown deadlock) and the chronic
antalya-26.3regression baseline.
Member
Audit: PR #1775 — Antalya 26.3 Backport of #100283 — Validate Iceberg metadata file path for null bytesAI audit note: This review comment was generated by AI (Cursor agent, audit-review skill). Confirmed defectsNo confirmed defects in reviewed scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix exception when Iceberg metadata file path setting contains a null byte (ClickHouse#100283 by @alexey-milovidov)
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: