Make the export task timeout 24 hours instead of 1 hour#1843
Conversation
arthurpassos
added
antalya
port-antalya
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 725f04dd49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| This setting does not affect / delete in progress tasks. It'll only cleanup the completed ones. | ||
| )", 0) \ | ||
| DECLARE(UInt64, export_merge_tree_partition_task_timeout_seconds, 3600, R"( | ||
| DECLARE(UInt64, export_merge_tree_partition_task_timeout_seconds, 86400, R"( |
There was a problem hiding this comment.
When a deployment sets compatibility to a version before this default bump, SettingsImpl::applyCompatibilitySetting only restores older defaults that are listed in SettingsChangesHistory.cpp. This change raises export_merge_tree_partition_task_timeout_seconds from 3600 to 86400 but leaves the history entry at the old 0 -> 3600 introduction, so compatibility sessions still get the new 24-hour timeout instead of preserving the previous 1-hour behavior. Please add a settings-history entry for this default change so older compatibility modes continue to kill pending export tasks after one hour.
Useful? React with 👍 / 👎.
Increased the default value for export_merge_tree_partition_task_timeout_seconds to 3600 seconds for better realism.
4 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Make the export task timeout 24 hours instead of 1 hour
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: