Skip to content

Stable-25.8: Fix consistently-failing stateless tests #2050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zvonand merged 8 commits into from
Jul 20, 2026
+9 −3
Merged

Stable-25.8: Fix consistently-failing stateless tests #2050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a21f85a
Enable allow_local_data_lakes in 04340_datalake_schema_deep_recursion…
CarlosFelipeOR Jul 15, 2026
ef49ac0
Skip 04299 constraint correlated subquery test under parallel replicas
CarlosFelipeOR Jul 15, 2026
40121cd
Skip 04326_parquet_v3_geoparquet_wkb_alloc test under ubsan
CarlosFelipeOR Jul 15, 2026
6358e06
Merge branch 'stable-25.8' into ci/test-fixes-stable-25.8
zvonand Jul 15, 2026
26d77a7
Backport no-old-analyzer tag support to clickhouse-test (fixes 04409/…
CarlosFelipeOR Jul 16, 2026
633669f
Mark 01710_projection_additional_filters broken on ParallelReplicas (…
CarlosFelipeOR Jul 16, 2026
b2dba68
Revert "Skip 04299 constraint correlated subquery test under parallel…
CarlosFelipeOR Jul 17, 2026
bbefc42
Revert "Mark 01710_projection_additional_filters broken on ParallelRe…
CarlosFelipeOR Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/clickhouse-test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,7 @@ class FailureReason(enum.Enum):
NO_STATEFUL = "no-stateful"
NO_OPENSSL_FIPS = "no-openssl-fips"
ENCRYPTED_STORAGE = "encrypted-storage"
OLD_ANALYZER = "old-analyzer"

# UNKNOWN reasons
NO_REFERENCE = "no reference file"
Expand Down Expand Up @@ -1548,6 +1549,9 @@ class TestCase:
if "no-parallel-replicas" in tags and args.no_parallel_replicas:
return FailureReason.NO_PARALLEL_REPLICAS

if "no-old-analyzer" in tags and is_old_analyzer_used(args):
return FailureReason.OLD_ANALYZER

if "no-async-insert" in tags and args.no_async_insert:
return FailureReason.NO_ASYNC_INSERT

Expand Down
3 changes: 2 additions & 1 deletion tests/queries/0_stateless/04326_parquet_v3_geoparquet_wkb_alloc.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
#!/usr/bin/env bash
# Tags: no-fasttest
# Tags: no-fasttest, no-ubsan
# no-fasttest: needs pyarrow to write the GeoParquet file.
# no-ubsan: memory tracking isn't reliably enforced in the standalone UBSan build (jemalloc off), so the oversized reserve isn't rejected. See Altinity/ClickHouse#2049.

# Regression test for an untracked-allocation DoS in the Parquet V3 GeoParquet (WKB) reader.
# The WKB reader took an element count straight off the wire and `reserve`d a std::vector of that
Expand Down
5 changes: 3 additions & 2 deletions tests/queries/0_stateless/04340_datalake_schema_deep_recursion.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ PYEOF

# allow_experimental_delta_kernel_rs=0 selects the C++ metadata parser (the Rust kernel has its own
# recursion limit). The deep schema must be rejected with a JSON exception, not crash the process.
$CLICKHOUSE_LOCAL --query "DESCRIBE TABLE deltaLakeLocal('$TMP_DIR/dl') SETTINGS allow_experimental_delta_kernel_rs=0 FORMAT Null" 2>&1 \
# allow_local_data_lakes=1 lifts the Altinity guard that otherwise disables the *Local table functions.
$CLICKHOUSE_LOCAL --query "DESCRIBE TABLE deltaLakeLocal('$TMP_DIR/dl') SETTINGS allow_experimental_delta_kernel_rs=0, allow_local_data_lakes=1 FORMAT Null" 2>&1 \
| expect_contains delta_depth JSONException

# Iceberg parses the whole metadata JSON with Poco before any field validation, so a deeply nested
Expand All @@ -58,5 +59,5 @@ N = 2000
open('$TMP_DIR/ice/metadata/v1.metadata.json', 'wb').write(b'{' + b'\"a\":{' * N + b'\"x\":1' + b'}' * N + b'}')
open('$TMP_DIR/ice/metadata/version-hint.text', 'w').write('1')
"
$CLICKHOUSE_LOCAL --query "DESCRIBE TABLE icebergLocal('$TMP_DIR/ice') FORMAT Null" 2>&1 \
$CLICKHOUSE_LOCAL --query "DESCRIBE TABLE icebergLocal('$TMP_DIR/ice') SETTINGS allow_local_data_lakes=1 FORMAT Null" 2>&1 \
| expect_contains iceberg_depth JSONException
Loading