Skip to content

24.8 Update regression hash, minor report fix #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2025
Merged

24.8 Update regression hash, minor report fix #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8bc907
24.8 Update regression hash
strtgbb Mar 4, 2025
9f89a64
Workaround uncertain dtype for report
strtgbb Mar 5, 2025
c1dceb1
Update to new regression hash
strtgbb Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/create_combined_ci_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def get_checks_known_fails(client: Client, job_url: str, known_fails: dict):
len(df.columns) - 1,
"reason",
df["test_name"]
.cat.remove_unused_categories()
.astype(str)
Copy link
Member

@Enmk Enmk Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a change unrelated to the regression hash

Copy link
Collaborator Author

@strtgbb strtgbb Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a fix for an occasional issue with report generation.

.apply(
lambda test_name: known_fails[test_name].get("reason", "No reason given")
),
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release_branches.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -539,7 +539,7 @@ jobs:
secrets: inherit
with:
runner_type: altinity-on-demand, altinity-type-cpx51, altinity-image-x86-app-docker-ce, altinity-setup-regression
commit: 53d73ed32155a8a17ee0d0cdb15aee96c98010a2
commit: 11dcb1ad771e6afebcb06bcc7bf1c1d8b184d838
arch: release
build_sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout_minutes: 300
Expand All @@ -550,7 +550,7 @@ jobs:
secrets: inherit
with:
runner_type: altinity-on-demand, altinity-type-cax41, altinity-image-arm-app-docker-ce, altinity-setup-regression
commit: 53d73ed32155a8a17ee0d0cdb15aee96c98010a2
commit: 11dcb1ad771e6afebcb06bcc7bf1c1d8b184d838
arch: aarch64
build_sha: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
timeout_minutes: 300
Expand Down
Loading