feat(#256): add complete chart style presets#259
Merged
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #256.
Extend the existing Line/Area Style selector to seven complete presentation presets while keeping advanced Spec combinations lossless and visible as disabled
Custom. Add exact pure preset matching/application, renderer semantics for scale/legend/grid/axes, canonical schema/completion support, and persistence coverage across saved/shared/Dashboard flows.Verification
npm test— 101 files, 2,813 tests passed; coverage gate passednpm run build— generated-schema check passed;dist/sql.htmlbuiltnpm run test:e2e— 115 passed on the initial matrix; five unrelated Firefox navigation/setup timeouts passed 5/5 withnpx playwright test --last-failedChecklist
npm testpasses (the per-file coverage gate is non-negotiable)npm run buildsucceeds (single-filedist/sql.html)src/core/, network insrc/net/(injected fetch), DOM insrc/ui/CHANGELOG.md([Unreleased]) updated if behavior or the deployed surface changed