feat(#258): add chart family style presets#260
Merged
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: Codex
Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Extends the existing single Style selector with type-specific Bar, Column,
Area, and Pie presentation presets while keeping advanced combinations in the
Spec editor. Every preset-owned presentation field lives in the canonical
panel.cfg.styleobject; dormant fields and unknown extensions survive typeswitches and the same configuration feeds workbench and Dashboard rendering.
Adds grouped/stacked bars, compact/joined density, additive stacked Area,
Pie/Donut shape, and a reduced-padding Compact Pie frame. Type-specific schema
branches and completion now expose the complete Style contract. Explicit
scale: "auto"resolves to the chart-family default: data range for Line/Areaand zero-based for Bar/Column.
Closes #258
Verification
npm test— 2,847/2,847 pass; 100% statements and linesnpm run build— pass (dist/sql.html, 1,208,155 bytes)npm run test:e2e— 116/120 pass under the first 10-worker run; fourunrelated Firefox
page.gotostartup timeouts before app code loadedChecklist
npm testpasses (the per-file coverage gate is non-negotiable)npm run buildsucceeds (single-filedist/sql.html)src/core/, DOM insrc/ui/CHANGELOG.mdupdated