feat(#464): disambiguate colliding tab origins - #539
Merged
Conversation
Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: unavailable (OpenAI Codex)
Co-Authored-By: OpenAI Codex <noreply@openai.com> Claude-Session: unavailable (OpenAI Codex)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Closes #464.
Same-named Workbench tabs now expose their source without widening every tab:
Draft badges;
Dashboard-variable tabs use their existing document binding;
focus handoff after activation/close, and a full
<source> / <document>tooltip;
states, while source abbreviations remain intact for Unicode graphemes;
order and behavior.
The issue body and ADR-0003 now reflect the #471 decision that
savedIdalreadyprovides stable query-tab identity; this PR deliberately adds no redundant
QueryTabOriginstate.Validation
npm test— pass; 100% statements/lines, 99.94% functions, 96.84% branchesnpm run build— pass; singledist/sql.htmland WebKit
failures reproduce on untouched base commit
3259b54close behavior, and badge disappearance verified
Checklist
npm testpasses (the per-file coverage gate is non-negotiable)npm run buildsucceeds (single-filedist/sql.html)src/core/, network insrc/net/(injected fetch), DOM insrc/ui/CHANGELOG.md([Unreleased]) updated if behavior or the deployed surface changed