Skip to content

chore(#455,#498): enforce src/core boundaries and catch openMenu extension classes - #554

Merged
BorisTyshkevich merged 1 commit into
mainfrom
chore/test-gates-435-455-498
Jul 29, 2026
Merged

chore(#455,#498): enforce src/core boundaries and catch openMenu extension classes#554
BorisTyshkevich merged 1 commit into
mainfrom
chore/test-gates-435-455-498

Conversation

@BorisTyshkevich

Copy link
Copy Markdown
Collaborator

What & why

Three low-priority gate/test-infra fixes with no user-facing behaviour change.

Closes #455build/check-boundaries.mjs had no src/core rule, so the invariant src/application/main-surface.ts documents ("src/core/ must never import src/workspace/") was not mechanically enforced. Adds the RULES entry, deliberately narrower than "no imports from any other layer" so the documented legacy type-only core/saved-io.tseditor/spec-editor.types.js dependency keeps passing. tests/unit/dashboard-boundaries.test.js gains a real-tree check plus a sabotage probe that plants a throwaway forbidden import inside src/core, asserts the detector flags it, and removes it in a finally — so the clean-tree assertion cannot go vacuous.

Closes #498 — the typography contract only scanned for class: '…' hyperscript literals, so every class supplied through openMenu/openConfirmMenu options (menuClass, extraClass, goClass, cancelClass) was invisible to it. Adds a separate openMenu extension classes have CSS rules test that walks all of src/ui/**/*.ts recursively (not a curated list, so new menu consumers are covered automatically), splits whitespace-separated class groups, and asserts each has a rule in src/styles.css. The existing generic scanner is untouched, so .file-menu/.fm-item/.fm-section stay covered. A sabotage test proves removing one such rule fails the contract.

The new scanner immediately surfaced one real gap: .dash-style-item (on every layout-picker row via buildLayoutMenu) had no rule at all. Added one — see the note below.

#435 needed no code change and is closed separately with the evidence. tests/unit/filter-bar.test.ts no longer exists: #459 renamed it to tests/unit/variable-bar.test.ts and replaced the four raw 0x00 bytes with a single escaped GROUP_KEY constant matching production. Verified independently — no file under src/ or tests/ on main contains a NUL byte (only PNGs do, as expected).

Reviewer note on the one CSS line

.dash-style-item { justify-content: space-between; } is a functional declaration added to satisfy a test gate, which deserves scrutiny. It is verifiably inert: every dash-style-item row sets trailing unconditionally (dashboardStyleKeyCaps(shortcut)), and .fm-trailing's margin-left: auto already absorbs all free space, so space-between has nothing left to distribute. It documents the row's existing intent rather than changing layout. Flagged deliberately rather than buried.

Checklist

  • npm test passes (the per-file coverage gate is non-negotiable)
  • Tests added/updated in the same change as the code
  • npm run build succeeds (single-file dist/sql.html)
  • Layers kept honest: pure logic in src/core/, network in src/net/ (injected fetch), DOM in src/ui/
  • No new runtime dependency
  • README / CHANGELOG.md ([Unreleased]) updated if behavior or the deployed surface changed
  • Reconciled affected tracked work (roadmap Roadmap to 1.0.0 #68, the issue body, ADR/CHANGELOG) if this change reshaped it

🤖 Generated with Claude Code

https://claude.ai/code/session_01GiubaoqEuBzAyo5C4P8Vqr

…tension classes, verify NUL fix

#455: add a build/check-boundaries.mjs RULES entry forbidding src/core from
importing src/workspace, src/application, src/ui, or src/net, matching the
invariant src/application/main-surface.ts already documented but nothing
mechanically enforced; extends tests/unit/dashboard-boundaries.test.js with a
real-tree check plus a sabotage test proving the rule actually catches a
violation.

#498: add a dedicated 'openMenu extension classes have CSS rules' test to
tests/unit/typography-contract.test.js that scans all of src/ui/**/*.ts for
literal menuClass/extraClass values, plus the goClass/cancelClass values
openConfirmMenu callers pass at their dash-tree-confirm*/qtab-close-confirm*/
dash-tile-confirm* call sites (confirm-menu.ts forwards these as extraClass,
so the literal lives at the caller). Includes a sabotage check. The scan
surfaced a real gap — dash-style-item (dashboard.ts's layout-picker row) had
no CSS rule at all — so src/styles.css now gives it one.

#435: tests/unit/filter-bar.test.ts's 4 raw NUL bytes were already fixed as a
side effect of the #459 filter-to-variable rename (now
tests/unit/variable-bar.test.ts, using one escaped GROUP_KEY constant).
Verified no raw NUL bytes remain under src/ or tests/; no code change needed.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GiubaoqEuBzAyo5C4P8Vqr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typography contract misses classes supplied through openMenu options Enforce src/core dependency boundaries in check-boundaries

1 participant