Skip to content

Conversation

@alirezadoostimehr
Copy link
Contributor

Fix Helm generation of priorityClassName; chart failed to template/install when set

When .Values.operator.priorityClassName was set, the line injected by dev/generate_helm_chart.sh produced a malformed Go-template fragment, resulting in broken YAML. That made helm template/install fail.
This change fixes the issue and conditionally renders priorityClassName with proper quoting, so the chart templates and installs correctly whether the value is set or not.


Thanks for taking the time to contribute to clickhouse-operator!

Please, read carefully instructions on how to make a Pull Request.

This will help a lot for maintainers to adopt your Pull Request.

Important items to consider before making a Pull Request

Please check items PR complies to:

  • All commits in the PR are squashed. More info
  • The PR is made into dedicated next-release branch, not into master branch1. More info
  • The PR is signed. More info

--

1 If you feel your PR does not affect any Go-code or any testable functionality (for example, PR contains docs only or supplementary materials), PR can be made into master branch, but it has to be confirmed by project's maintainer.

…nal in clickhouse-operator deployment

Signed-off-by: Alireza Doostimehr <alirezadoostimehr@gmail.com>
@alirezadoostimehr
Copy link
Contributor Author

@Slach Thanks for the review and approval. The pipelines are complete and ready to merge.

@Slach Slach merged commit 2269505 into Altinity:0.25.4 Aug 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants