fix: use plain errors for clickhouse model messages#1980
Merged
sunsingerus merged 1 commit intoAltinity:0.27.0from May 8, 2026
Merged
fix: use plain errors for clickhouse model messages#1980sunsingerus merged 1 commit intoAltinity:0.27.0from
sunsingerus merged 1 commit intoAltinity:0.27.0from
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
sunsingerus
approved these changes
May 8, 2026
Collaborator
sunsingerus
left a comment
There was a problem hiding this comment.
LGTM. Tiny, correct vet cleanup — fmt.Errorf(s) → errors.New(s) at 3 sites in pkg/model/clickhouse. Verified:
- Functional equivalence: identical
*errors.errorStringoutput whenshas no%verbs; no callers useerrors.Is/errors.Ason these errors. - Sweep is complete for the package:
go vet ./pkg/model/clickhouse/flags exactly these 3 sites. - Go version claim is accurate: go.mod declares
go 1.26.2. - Format-injection rationale is real (SQL interpolates user-controlled cluster names), though theoretical in Go (memory-safe fmt).
Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiny vet cleanup in the ClickHouse model package.
Go 1.26 flags
fmt.Errorf(s)whensis already a built string. No formatting needed here, soerrors.New(s)is the straight shot. same behavior, less noise.Repro before:
go test ./pkg/model/clickhouseIt failed with:
After:
go test ./pkg/model/clickhousepasses