chore(dotnet): add Altium.Auth.sln (src/tests/tools) for IDE + soluti… - #2
Merged
Conversation
…on-level build/test
…+ build-offline.sh (xUnit covers the same vectors)
There was a problem hiding this comment.
Pull request overview
This PR streamlines the .NET developer workflow by introducing a solution file for IDE/solution-level builds, tightening code-quality enforcement for the shipped Altium.Auth library, and updating docs/CI guidance accordingly. It also removes the dependency-free offline conformance runner and restructures some public types into separate source files.
Changes:
- Add
libs/dotnet/Altium.Auth.slnand update docs to prefer solution-leveldotnet build/test. - Enable analyzers + warnings-as-errors for the shipped library and add
.editorconfig+ StyleCop structural rules. - Remove the offline conformance console runner (
tests/Altium.Auth.Conformance) and its helper script.
Reviewed changes
Copilot reviewed 20 out of 26 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/dotnet/tests/Altium.Auth.Tests/ConformanceTests.cs | Updates developer guidance comment for running conformance tests. |
| libs/dotnet/tests/Altium.Auth.Tests/Altium.Auth.Tests.csproj | Simplifies project comment to reflect new solution-based workflow. |
| libs/dotnet/tests/Altium.Auth.Conformance/Program.cs | Removes the offline, dependency-free conformance console runner implementation. |
| libs/dotnet/tests/Altium.Auth.Conformance/ConformanceTests.cs | Removes placeholder notes for the offline conformance runner project. |
| libs/dotnet/tests/Altium.Auth.Conformance/Altium.Auth.Conformance.csproj | Removes the offline conformance runner project file. |
| libs/dotnet/src/Altium.Auth/WorkspaceSelection.cs | Introduces a public enum for workspace selection behavior during authorization/sign-in. |
| libs/dotnet/src/Altium.Auth/TokenSet.cs | Extracts the token response DTO into a dedicated public type. |
| libs/dotnet/src/Altium.Auth/IAltiumAuthClient.cs | Introduces a public client interface for the library surface area. |
| libs/dotnet/src/Altium.Auth/AuthorizationRequest.cs | Extracts the authorization request record into a dedicated public type. |
| libs/dotnet/src/Altium.Auth/AltiumEndpoints.cs | Extracts endpoint presets into a dedicated public type. |
| libs/dotnet/src/Altium.Auth/AltiumAuthOptions.cs | Refactors options to rely on the new AltiumEndpoints type and improves documentation. |
| libs/dotnet/src/Altium.Auth/AltiumAuthClient.cs | Refactors implementation to use extracted public types and improves async + JSON exception handling. |
| libs/dotnet/src/Altium.Auth/Altium.Auth.csproj | Enables analyzers/code-style enforcement and adds a dev-only StyleCop analyzer package reference. |
| libs/dotnet/README.md | Updates development commands to use solution-level build/test and documents analyzer gating. |
| libs/dotnet/build-offline.sh | Removes the offline build/test helper script. |
| libs/dotnet/Altium.Auth.sln | Adds a Visual Studio solution grouping src/tests/tools for IDE and solution-level builds. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/vcs.xml | Adds Rider/IDEA VCS mapping configuration. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/misc.xml | Adds Rider/IDEA miscellaneous configuration. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/LNKD.tech Editor.xml | Adds IDE plugin configuration data. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/indexLayout.xml | Adds Rider/IDEA index layout configuration. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/.name | Adds Rider/IDEA project name metadata. |
| libs/dotnet/.idea/.idea.Altium.Auth/.idea/.gitignore | Adds Rider/IDEA-local ignore rules within the committed .idea tree. |
| libs/dotnet/.editorconfig | Adds Roslyn/StyleCop analyzer configuration for .NET code-style and naming enforcement. |
| CONTRIBUTING.md | Updates contributor commands to use solution-level build/test. |
| AGENTS.md | Updates validation cheat-sheet to use solution-level testing for .NET. |
| .github/workflows/dotnet-ci.yml | Removes offline runner invocation; keeps CI focused on xUnit tests and tool build. |
Files not reviewed (6)
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/.gitignore: Generated file
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/.name: Generated file
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/LNKD.tech Editor.xml: Generated file
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/indexLayout.xml: Generated file
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/misc.xml: Generated file
- libs/dotnet/.idea/.idea.Altium.Auth/.idea/vcs.xml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1
to
+6
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="VcsDirectoryMappings"> | ||
| <mapping directory="$PROJECT_DIR$/../.." vcs="Git" /> | ||
| </component> | ||
| </project> No newline at end of file |
Comment on lines
+1
to
+5
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="MetaFilesCheckinStateConfiguration" checkMetaFiles="true" /> | ||
| <component name="UnityCheckinConfiguration" checkUnsavedScenes="true" /> | ||
| </project> No newline at end of file |
Comment on lines
+1
to
+8
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="UserContentModel"> | ||
| <attachedFolders /> | ||
| <explicitIncludes /> | ||
| <explicitExcludes /> | ||
| </component> | ||
| </project> No newline at end of file |
| @@ -0,0 +1 @@ | |||
| Altium.Auth No newline at end of file | |||
Comment on lines
+1
to
+13
| # Default ignored files | ||
| /shelf/ | ||
| /workspace.xml | ||
| # Rider ignored files | ||
| /projectSettingsUpdater.xml | ||
| /.idea.Altium.Auth.iml | ||
| /modules.xml | ||
| /contentModel.xml | ||
| # Editor-based HTTP Client requests | ||
| /httpRequests/ | ||
| # Datasource local storage ignored files | ||
| /dataSources/ | ||
| /dataSources.local.xml |
Comment on lines
+1
to
+5
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <project version="4"> | ||
| <component name="http://lnkd.tech/editor#BuiltinGlobalGraphs"> | ||
| <option name="disabled"> | ||
| <set> |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…eveloper/a365-auth into chore/cleanup-dotnet-lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…on-level build/test