feat: adding inline chat telemetry - #2001
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2001 +/- ##
==========================================
+ Coverage 61.03% 61.10% +0.06%
==========================================
Files 239 239
Lines 52155 52232 +77
Branches 3117 3135 +18
==========================================
+ Hits 31835 31916 +81
+ Misses 20261 20256 -5
- Partials 59 60 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
suprajaven
marked this pull request as ready for review
July 29, 2025 12:17
francescoopiccoli
approved these changes
Jul 29, 2025
| this.#inlineChatLanguage = triggerContext.programmingLanguage?.languageName | ||
| this.#inlineChatTriggerType = ChatTriggerType.MANUAL | ||
| this.#inlineChatCustomizationArn = this.#customizationArn | ||
| this.#inlineChatRequestLength = params.prompt?.prompt?.length ?? 0 |
Contributor
There was a problem hiding this comment.
Suggested change
| this.#inlineChatRequestLength = params.prompt?.prompt?.length ?? 0 | |
| this.#inlineChatRequestPromptLength = params.prompt?.prompt?.length ?? 0 |
Contributor
Author
There was a problem hiding this comment.
Ack, if no other major comments I shall retain this behaviour - If others popup, I shall update this in the next followup commit.
rahmaniaam
reviewed
Jul 29, 2025
|
|
||
| this.#log('Response for inline chat', JSON.stringify(response.$metadata), JSON.stringify(response)) | ||
| } catch (err) { | ||
| this.#log(`Inline Chat Service Invocation Failed: ${err instanceof Error ? err.message : 'unknown'}`) |
Contributor
There was a problem hiding this comment.
should we add failed invocation metrics as well? Would be useful as well
rahmaniaam
approved these changes
Jul 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Solution
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.