Show WButton group conflict warnings when foldouts are collapsed by Copilot · Pull Request #251 · Ambiguous-Interactive/unity-helpers

Copilot · 2026-04-29T22:17:42Z

Description

Conflicting groupPlacement values were detected internally but could be effectively invisible when WButton groups started collapsed, which made misconfiguration easy to miss.
This updates warning rendering so conflicts remain visible regardless of foldout state and adds regression coverage for collapsed groups.

Warning visibility fix
- Moved conflict warning rendering outside foldout content so warnings are shown for collapsed groups.
- Keeps existing conflict resolution behavior unchanged (first declared value remains canonical).
Scope of conflicts covered
- Applies consistently to all existing WButton conflict warnings:
  - draw order
  - group priority
  - group placement
Regression test coverage
- Added collapsed-foldout tests in WButtonConflictWarningDisplayTests for all three warning types.
- Added internal test accessors for warning text caches to assert warning generation in StartCollapsed mode.

// WButtonGUI.cs (conceptual flow)
DrawConflictWarnings(groupKey); // now rendered before foldout body visibility checks
if (effectiveExpanded)
{
    DrawGroupContent(groupKey, contexts, paginationStates, triggeredContexts);
}

Related Issue

Addresses the linked bug report for missing user-visible feedback on conflicting WButton group placements.

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Refactor (code change that neither fixes a bug nor adds a feature)

Checklist

I have added tests that prove my fix is effective or my feature works
I have updated the documentation accordingly
I have updated the CHANGELOG
My changes do not introduce breaking changes, or breaking changes are documented

Agent-Logs-Url: https://github.com/wallstop/unity-helpers/sessions/3c78021c-03d2-420e-975a-3ef953b6d893 Co-authored-by: wallstop <1045249+wallstop@users.noreply.github.com>

Copilot

Pull request overview

This PR fixes an Editor UX gap in the WButton UI by ensuring conflict warnings (draw order / group priority / group placement) remain visible even when WButton groups start collapsed, and adds regression tests to prevent the issue from reappearing.

Changes:

Render WButton conflict warnings outside the foldout body so they show even when a group is collapsed.
Add internal test accessors for warning text caches to enable assertions in collapsed-foldout scenarios.
Add regression tests covering collapsed-foldout warning visibility for placement, priority, and draw order conflicts.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs	Adds regression tests asserting conflict warnings are generated/rendered when foldouts start collapsed.
Editor/Utils/WButton/WButtonGUI.cs	Moves conflict warning rendering out of foldout content gating and adds internal cache accessors for tests.

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 17 out of 18 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

Copilot

Pull request overview

Copilot reviewed 21 out of 22 changed files in this pull request and generated no new comments.

Copilot

Pull request overview

Copilot reviewed 85 out of 86 changed files in this pull request and generated 1 comment.

 check_npm_tool() {
    local name="$1"
    local cmd="$2"
    local version_flag="${3:---version}"
+    local output=""
+    local status=0

    printf "%-20s" "$name:"
-    if npx --no-install "$cmd" $version_flag >/dev/null 2>&1; then
-        version=$(npx --no-install "$cmd" $version_flag 2>&1 | head -1)
+    if output="$(timeout 30s npx --no-install "$cmd" $version_flag 2>&1)"; then
+        version=$(printf '%s\n' "$output" | head -1)
        printf "${GREEN}✓${NC} %s (via npx)\n" "$version"
        return 0
    else
-        printf "${RED}✗ NOT FOUND - run 'npm install'${NC}\n"
+        status=$?
+        if [ "$status" -eq 124 ]; then
+            printf "${RED}✗ TIMED OUT - npx %s %s${NC}\n" "$cmd" "$version_flag"
+        else
+            printf "${RED}✗ NOT FOUND - run 'npm install'${NC}\n"
+        fi
        FAILED=$((FAILED + 1))
        return 1
    fi


Copilot

Pull request overview

Copilot reviewed 89 out of 103 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

scripts/verify-devcontainer-tools.sh:85

This script still validates repo-pinned npm tools via npx --no-install, but the rest of the repo has switched to invoking pinned Node CLIs through the repo-local launchers (scripts/run-prettier.js and scripts/run-node-bin.js). Using npx here can give inconsistent results (e.g., PATH/npx quirks or .bin shim behavior) and makes the verification less representative of how hooks/CI actually run these tools. Consider switching these checks to the same repo-local launchers used elsewhere.

        [SetUp]
        public virtual void BaseSetUp()
        {
 #if REFLEX_PRESENT
            EnsureReflexSettings();
 #endif
 #if UNITY_EDITOR
+            CleanupPackageRootGeneratedArtifacts();
            _previousEditorUiSuppress = EditorUi.Suppress;
            EditorUi.Suppress = true;


+# Validate the results path before creating the test project. Writing a Unity
+# project or test output under WORKSPACE_DIR makes those generated files part of
+# the imported package and can trigger Unity import-loop failures.
+RESULTS_DIR="${UNITY_TEST_PROJECT_DIR}/test-results"
+workspace_realpath="$(cd "${WORKSPACE_DIR}" && pwd -P)"
+results_realpath="$(realpath -m "${RESULTS_DIR}")"
+case "${results_realpath}" in
+    "${workspace_realpath}"|"${workspace_realpath}"/*)
+        echo "ERROR: Refusing to write Unity test results inside the package root: ${results_realpath}"
+        echo "ERROR: Set UNITY_TEST_PROJECT_DIR outside ${workspace_realpath} to avoid Unity package import loops."
+        exit 1
+        ;;
+esac


Initial plan

e8a12a3

Copilot AI assigned Copilot and Eli Pinkerton (wallstop) Apr 29, 2026

Copilot started work on behalf of Eli Pinkerton (wallstop) April 29, 2026 22:17 View session

Copilot AI linked an issue Apr 29, 2026 that may be closed by this pull request

[Bug]: No User-Visible Error When Conflicting Placements for a WButton Groups #129

Closed

8 tasks

Copilot AI and others added 3 commits April 29, 2026 22:25

fix: always show WButton conflict warnings for collapsed groups

2b2d4bd

Agent-Logs-Url: https://github.com/wallstop/unity-helpers/sessions/3c78021c-03d2-420e-975a-3ef953b6d893 Co-authored-by: wallstop <1045249+wallstop@users.noreply.github.com>

test: harden collapsed conflict warning coverage

7256d52

Agent-Logs-Url: https://github.com/wallstop/unity-helpers/sessions/3c78021c-03d2-420e-975a-3ef953b6d893 Co-authored-by: wallstop <1045249+wallstop@users.noreply.github.com>

refactor: clarify collapsed foldout expansion state naming

d7771cc

Agent-Logs-Url: https://github.com/wallstop/unity-helpers/sessions/3c78021c-03d2-420e-975a-3ef953b6d893 Co-authored-by: wallstop <1045249+wallstop@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Fix conflicting placements in WButton Groups to display user warnings~~ Show WButton group conflict warnings when foldouts are collapsed Apr 29, 2026

Copilot finished work on behalf of Eli Pinkerton (wallstop) April 29, 2026 22:28

Copilot AI requested a review from Eli Pinkerton (wallstop) April 29, 2026 22:28

Eli Pinkerton (wallstop) marked this pull request as ready for review April 29, 2026 22:28

Copilot AI review requested due to automatic review settings April 29, 2026 22:28

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) April 29, 2026 22:29 View session

Copilot AI reviewed Apr 29, 2026

View reviewed changes

Eli Pinkerton (wallstop) added 2 commits April 29, 2026 22:03

Test fixes

edbb4ea

Test fixes

66a7c9c

Eli Pinkerton (wallstop) requested a review from Copilot April 30, 2026 05:57

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) April 30, 2026 05:58 View session

Format changelog

5e230e0

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs Outdated

Comment thread Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs Outdated

Comment thread CHANGELOG.md

Eli Pinkerton (wallstop) requested a review from Copilot April 30, 2026 06:15

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) April 30, 2026 06:16 View session

Copilot AI reviewed Apr 30, 2026

View reviewed changes

Comment thread Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs

Comment thread CHANGELOG.md

Comment thread Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs

PR feedback

cbb233b

Eli Pinkerton (wallstop) requested a review from Copilot May 1, 2026 18:26

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) May 1, 2026 18:27 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread package.json

PR feedback

17b83e7

Eli Pinkerton (wallstop) requested a review from Copilot May 1, 2026 19:05

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread Tests/Editor/WButton/WButtonConflictWarningDisplayTests.cs

PR feedback

f4f1047

Eli Pinkerton (wallstop) requested a review from Copilot May 1, 2026 20:57

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) May 1, 2026 20:57 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Test and runtime fixes

ee9cc63

Eli Pinkerton (wallstop) requested a review from Copilot May 8, 2026 17:22

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) May 8, 2026 17:23 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

PR feedback

50f5993

Eli Pinkerton (wallstop) requested a review from Copilot May 8, 2026 19:44

Copilot started reviewing on behalf of Eli Pinkerton (wallstop) May 8, 2026 19:45 View session

Copilot AI reviewed May 8, 2026

View reviewed changes

Eli Pinkerton (wallstop) merged commit 3616f0f into main May 8, 2026
43 checks passed

Eli Pinkerton (wallstop) deleted the copilot/fix-wbutton-group-placement branch May 8, 2026 19:52

Uh oh!

Conversation

Copilot AI commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Type of Change

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Apr 29, 2026 •

edited

Loading