Failed to load funscript

[peterferenc8-coder]

Hello! Just started using the app. Could it be that you can not play funscripts that are longer than 5 minutes, or around that?

Also, very great app, other than that, works perfectly for me!

[Amethyst-Sysadmin]

I've used funscripts that are several hours long with no problems. Probably it's an issue with that specific script and there's something about how it's formatted that breaks our processing. If you can link or upload the funscript in question, I'll take a look and see if I can figure out why it doesn't load.

[peterferenc8-coder]

.funscript is not supported by GitHub, renamed them to .json. Shouldn't change the original content.

From https://faptap.net/v/1598236663107031042
BJQueen.json

From https://faptap.net/v/1679376964919496706
MollyRedwolf .json

From https://faptap.net/v/1689470821967335426
SweetieFox .json

All give back "Failed to load funscript: invalid funscript file"

Thanks once again!

[Amethyst-Sysadmin]

The reason it won't load is that some of the "at" values in the script (which are the timestamps in milliseconds) are fractional. For example in the first one, one of the problematic data points is {"at":161816.5,"pos":100}

My opinion is that the timestamps should always be whole numbers and that fractional values are not allowed. It's not like there is an "official" funscript spec really, but I've got 300 or so funscripts from Eroscripts that I've tried, and haven't seen any where the creator used fractional values. So I feel like there's probably an issue on FapTap's side with how they are storing or retrieving this data.

I think more evidence for that is that I was able to find SlowScripter's original thread for that "BJ Queen" script on Eroscripts (free registration needed to view). The funscript attached there seems to be almost identical and have most of the same points, but not the weird broken ones (oddly they aren't even there without the fractional part, FapTap just seems to have created a few additional points and added them in).

If you open the broken scripts in a text editor and just replace every instance of ".5" with nothing, that should make them loadable. But I'd suggest tracking down the original scripts from their creators instead where possible, as that site seems to be mangling them slightly.

I only checked the first one you posted, but assume they all probably have the same issue.

[peterferenc8-coder]

Indeed, that was the problem. No clue why that site does what it does to the scripts. Thank you, everything works perfectly!

[Amethyst-Sysadmin]

No worries. I emailed a bug report to FapTap, hopefully they can take a look at what's going on there.

[Vpn33]

@peterferenc8-coder I fixed this problem in my fork, you can build by your self 。

https://github.com/Vpn33/Howl

Add a custom Action.at serialization tool, setting the 'at' attribute as a double type and
truncating the decimal part to avoid the issue of unexpected .5 values in scripts like faptap.

[Amethyst-Sysadmin]

I've committed a fix in 0.8.1 that should allow funscripts with decimal values in these fields to load.