Fix scroller - 6BPP & 7BPP, fix HiRes#280
Merged
Merged
Conversation
tehKaiN
reviewed
Jun 15, 2026
tehKaiN
left a comment
Member
There was a problem hiding this comment.
Generally looks good.
I'm not sure whether those extended aga-related ifs/switches in fetchmode.h won't introduce extra overhead for ocs since there's no e.g. ifdef aga in calculating bitplane shift, but if that happens we'll add hot paths.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix scroll buffer display setup for higher bit depths and hires modes.
This PR improves scroll buffer behavior for 6bpp and 7bpp in FMODE 0, 1, and 3. FMODE 3 is usable but still shows minor horizontal black-line glitches.
It also fixes hires mode setup by correctly composing and writing
BPLCON0, and simplifies the relatedBPLCON0andBPLCON2logic insrc/ace/utils/extview.c.Known limitation: 8bpp scroll buffer modes are still not fixed. They likely need a deeper change to the scrolling/wrapping mechanism because the current Copper update approach appears to exceed available timing.
Checklist