fix(test): stabilize watcher healthy-peer restart fixture - #9
Merged
Conversation
Wait for the fixture's SIGTERM handler before exercising restart so startup scheduling cannot turn the healthy-peer case into the child-owned path. Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/fm-watcher-lock.test.shhealthy-peer restart case that timed out at 80s (status 124) on unmodified main.restart did not exit zero after reporting healthy peer (status 124)— 124 is the fixture timeout, not an assertion mismatch. Reproduced deterministically when the peer was still in startup (handler not installed). After waiting for an explicit readiness marker written only after the SIGTERM handler is installed, restart correctly reports the healthy peer and exits 0 without attaching.Test plan
bash tests/fm-watcher-lock.test.sh— at least 5 consecutive green runs in isolation on the task machine (predecessor + 2 reconfirm runs after recovery)