Skip to content

Gcp nextflow container#28

Merged
samwachspress merged 14 commits intomasterfrom
gcp-nextflow-container
Oct 5, 2021
Merged

Gcp nextflow container#28
samwachspress merged 14 commits intomasterfrom
gcp-nextflow-container

Conversation

@samwachspress
Copy link
Copy Markdown
Contributor

Previous "nemascan" container was actually the "nemascan-worker" container (which nextflow uses for each stage), but there was not a formal container for initializing the nextflow pipeline itself in google cloud (that environment was manually configured by users).
For the last project cycle I created the "nemarun" container in the dockerfile repo, but in fact that container should be part of this repo instead. I will also rename the existing "nemascan" container to "nemascan-worker" to make the distinction clear in the future.

Creates a new "andersenlab/nemascan-nxf" container
Adds documentation for running, modifying, testing, and releasing new versions of the container

Copy link
Copy Markdown
Contributor

@katiesevans katiesevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I was able to follow your steps to run myself in GCP. I noticed in the output there is no font, just weird boxes. We saw this before, I'm not sure how you fixed it before (maybe adding a font to the nemarun container?) but it probably makes most sense for me to add the font to the nemascan container that is called with -profile gcp so I can update that

Comment thread README.md

To start a terminal session inside of the container, use:
```
docker run -i -t andersenlab/nemascan-nxf /bin/bash
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this error docker: Error response from daemon: manifest for andersenlab/nemascan-nxf:latest not found but it worked if I gave it the specific version (v0.01). Not sure why "latest" can't be found

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, ill look into it.

Comment thread README.md
-e OUTPUT_DIR="gs://elegansvariation.org/reports/nemascan/abcd123/results" \
-e WORK_DIR="gs://nf-pipelines/workdir/abcd123" \
-e VCF_VERSION="20210121" \
andersenlab/nemascan-nxf \
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here with the version. I see you added it above ^

@samwachspress
Copy link
Copy Markdown
Contributor Author

Yeah, I noticed the fonts issue as well, I am trying to test with some different R font packages in the nemascan-worker container

@katiesevans
Copy link
Copy Markdown
Contributor

When I had this issue with another container I just added mscorefonts to the docker and that seemed to fix it

@samwachspress
Copy link
Copy Markdown
Contributor Author

That's how I resolved it the first time, not sure what caused it to break unless this is using a different nemascan-worker container, though.

@katiesevans
Copy link
Copy Markdown
Contributor

Sam, I noticed the gcp profile is using a different nemascan container. Where is that and how is it different than the docker I built to run on quest? We should probably converge those too on the andersenlab dockerhub

@samwachspress
Copy link
Copy Markdown
Contributor Author

samwachspress commented Sep 29, 2021 via email

@samwachspress samwachspress merged commit cc2a4e3 into master Oct 5, 2021
mckeowr1 pushed a commit that referenced this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants