Feature/update compilers#7
Merged
Merged
Conversation
Adds FLOW_BOUND_ATTR marker and bindFlowEventsIn scope helper. Prevents duplicate listener registration when bindFlowEvents is called multiple times on the same DOM. Also introduces consolidated compiler improvement plan docs.
A2: translate FlowmarkDomDiagnostic locations to original Astro file
coordinates in @flowmark/astro-events.
A3: reject trailing content after event handler calls in parser.ts.
A4: replace regex-based event discovery with HTML-aware scanner that
skips comments, script/style tags, and respects quoted values.
Updates improvement plan and session context to mark Phase A done.
B1: support export/async function declarations in frontmatter.
B2: detect arrow functions and function expressions and emit a
helpful diagnostic telling users to convert to function declarations.
B3: replace heuristic capture analyzer with TypeScript type checker.
Identifiers are captures when their symbol declarations are outside
the handler source file and they are not known globals.
Adds typescript as a runtime dependency of @flowmark/dom.
Updates improvement plan and session context.
C1: add warning diagnostics for in @for (FM0015). Add to , surface them in CLI and Vite. C2: always emit after @switch cases to prevent accidental fallthrough. C3: improve error message for partial interpolations in quoted attributes. C4: point unclosed-tag diagnostics to the opening tag span. C5: rename generated temporaries to and . Updates improvement plan and session context.
D1: add magic-string dependency and generate source maps for
@flowmark/astro-events transformed Astro files.
D2: return an unbind function from bindFlowEvents and bindFlowEventsIn
so callers can remove attached listeners and rebind later.
D3: add regression test verifying </script> sequences inside injected
client modules are escaped to avoid breaking the script tag.
Updates improvement plan, session context and lockfile.
Development phases A-D are complete; these files are no longer needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
pnpm run testpnpm run buildpnpm run test:e2e:demofor language/integration changesNotes