Split export state into a read-only merged exported and a host-owned meta_exported switch - #5
Merged
Conversation
…d `meta_exported` switch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Message.exportedis now read-only: True when an nbdev export directive is present in either the content comments or the metanbdevdict, merged with comments winning, matching nbdev's own rule. The new read-writeMessage.meta_exportedcovers only the meta entry: assigning True writesmeta['nbdev']['export']='true', assigning False removes the entry, and content is never touched.The two sources have different owners - a
#|line is text the user edits directly, the meta entry is the host's switch - so the old setter's silent migration (hoisting a content directive into meta on assignment) is gone along with the ambiguity it papered over.Breaking: assigning
Message.exportednow raises. Hosts that toggled export state through it should assignmeta_exportedinstead; code that only readexportedis unchanged.