Assert the tool round-trip property instead of the signature repr - #2
Merged
Conversation
With toolslm carrying param descriptions as Annotated metadata, the signature repr changed; replace the byte-exact assertion with the guarantee it stood for: a rebuilt tool re-derives the exact schema it was served from. Needs toolslm>=0.3.47 (already pinned). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DHkskFwAKk5LNW4xMpeZFP
Contributor
|
Thanks @erikgaas . If you have a moment, it might be nice to clean up the now-extremely-giant sentence "Against the live server started above: the handshake carries the instructions across, the rebuilt tool re-derives the exact schema it was served from (descriptions included, carried as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to AnswerDotAI/toolslm#99, which makes
mk_tool-rebuilt tools carry param descriptions asAnnotatedmetadata. That changes the signature repr, breaking the byte-exact assertion here:Replaced with the guarantee it stood for, checked over the live HTTP round trip:
This makes the notebook's own claim ("comes back out the other with its signature, docs, and defaults intact") fully true — previously per-param descriptions were dropped. Needs the toolslm PR (the
toolslm>=0.3.47pin already covers it per the bump-after-release convention).nbdev-test --path nbs/00_core.ipynbgreen with that branch.