Fix procedure-hitl metadata guard warning from PR #121#128
Merged
dereknorrbom merged 1 commit intodevfrom Mar 18, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fix for a remaining GitHub Code Quality warning on PR #121 in
dashboard/lib/procedure-hitl.ts.Change
Adjusted
parseMessageMetadataguard conditions to avoid redundant/null-impossible comparisons while preserving behavior:if (!metadata) return null, object guard now checks onlytypeof metadata === 'object' && !Array.isArray(metadata).typeof parsed === 'object' && parsed !== null && !Array.isArray(parsed).Validation
npx jest lib/__tests__/procedure-hitl.test.ts --runInBand6 passedRelated
devintomain: PITR enablement, procedure runtime updates, and dashboard/MCP fixes #121plx-a050e9