Update to 1.21.3/1.21.4 by Xtendera · Pull Request #399 · AntiCope/meteor-rejects

Xtendera · 2024-12-22T05:27:51Z

Builds

Testing builds are now available.

Build 2 (1.21.4):
Some shaders in the rendering modules have restored functionality.
Artifact Download

Description

I am attempting to update this addon to 1.21.3. There is a lot of changes so bare with me while I attempt to fix everything.

Related Issue

#397

Motivation and Context

This project is a bit backlogged, I totally get it and I will try to lessen the work for maintainers.

How Has This Been Tested?

I will individually test some features once it starts working, but I will ask for other people's help to make sure everything works properly and will make changes as needed.

Roadmap (Not all changes may be committed yet, this is specifically for my own tracking)

⚠️Rendering.java (See below)

ShieldBypass.java

⚠️SkeletonESP.java (See below)

SoundLocator.java
GiveUtils.java
RejectUtils.java
WorldUtils.java

⚠️ Issues with SkeletonESP and Shaders

In Minecraft 1.21.2, Minecraft's rendering system was rewritten, breaking some of the code used in many modding projects, including this one. There is work being done to transition old code over to the new system, but it will take some time. For now, expect that some parts of the SkeletonESP Module and the Shaders feature of the Rendering module will be broken until further notice.

Don't expect it to work anytime soon.

Xtendera · 2024-12-22T06:33:44Z

By the way, my changes for AutoCraft.java are quite weird, if someone could verify that it logically makes sense and lines up with previous logic that would be great.

Had to revert gradle to 8.10 due to unforseen issues.

ml3czus · 2024-12-22T18:19:49Z

OMG U GOT IT ❤️❤️

Xtendera · 2024-12-22T18:33:20Z

We're in boys.

On first glance everything seems to be working fine. Please lmk of any issue you encounter.

ml3czus · 2024-12-22T19:00:41Z

ILYSM ❤️❤️

crazymoose7 · 2024-12-25T21:53:45Z

Without opening IDE
it seems line 47 in WorldUtils might be able to be replaced with : mc.player.setSneaking(false);
Rendering.java have you tried mc.getShaderLoader().loadPostEffect() and pass in the ID and DefaultFramebufferSet.STAGES ?

Willtest and take a look at autocraft soon.

ml3czus · 2024-12-25T21:57:57Z

also AutoLogin wont save passwords after register with the create strong password option

Xtendera · 2024-12-26T16:23:02Z

Without opening IDE it seems line 47 in WorldUtils might be able to be replaced with : mc.player.setSneaking(false); Rendering.java have you tried mc.getShaderLoader().loadPostEffect() and pass in the ID and DefaultFramebufferSet.STAGES ?

Willtest and take a look at autocraft soon.

I will also look into it soon. Yes line 47 of WorldUtils is overcomplicated lol. I have not tried the getShaderLoader thing, but I will see if that works hopefully today.

also AutoLogin wont save passwords after register with the create strong password option

Will also look into this 👍🏽

Xtendera · 2024-12-30T01:13:41Z

@crazymoose7 Okay after some testing the loadPostEffect method does not seem to work in it's current state, it is causing a black screen on launch. I will attempt to move it around (maybe even by mixining some other methods that use it) to see if it could just be a placement thing. I also tried MAIN_ONLY and MAIN_AND_ENTITY_OUTLINE and neither work properly.

crazymoose7 · 2024-12-30T21:22:41Z

@Xtendera I think something worth noting is the different shaders in the shaders/post directory, while not directly connected to this issue. The current enum hasnt been updated to reflect changes.
Did the log output provide anything ?

vanvac · 2025-01-09T17:23:58Z

will this pr be migrated to 1.21.4 or finish the 1.21.3 update and then work on 1.21.4?

Xtendera · 2025-01-09T19:12:36Z

@Xtendera I think something worth noting is the different shaders in the shaders/post directory, while not directly connected to this issue. The current enum hasnt been updated to reflect changes. Did the log output provide anything ?

Sorry for the late response. Nope, the log output was completely clear, and it seemed that the on screen buttons also worked, just nothing was actually rendered.

will this pr be migrated to 1.21.4 or finish the 1.21.3 update and then work on 1.21.4?

1.21.4 is super easy I will work on that soon. It was the 1.21.2 update that really caused issues. Of course renderer and skeleton might still stay broken/

areume669 · 2025-01-13T14:08:33Z

How do I download this??

vanvac · 2025-01-13T17:25:11Z

Not for 1.21.4 https://github.com/AntiCope/meteor-rejects/actions/runs/12456969030 download the artifact file from this github action and unzip for the 1.21.3 version please note the some render related things are broken due to changes with 1.21.2-3

fortune428 · 2025-01-14T05:18:27Z

when loading the world,the game will crashes,I dont know the reason
game version is1.21.4

crazymoose7 · 2025-01-14T16:21:16Z

progress on the Rendering Module ! @Xtendera - Edit : PR for draft

might as well make this 1.21.4 and format version to the new addon version as well

vanvac · 2025-01-14T19:36:13Z

pretty sure its a Mixin crash
https://mclo.gs/5wmfGT1
happens when joining a world after it loads to 100%

crazymoose7 · 2025-01-14T20:16:40Z

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.

Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well.
https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Small rendering fixes (hopefully)

Xtendera · 2025-01-15T02:18:52Z

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.

Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

crazymoose7 · 2025-01-15T02:21:31Z

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.
Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

I had removed the commented line after I believe it is not needed any more perhaps ? I had looked at examples of changes in some of minecrafts own Entities and the changes you made already seemed to be suitable. Let me know what you see !

Xtendera · 2025-01-16T01:08:36Z

pretty sure its a Mixin crash https://mclo.gs/5wmfGT1 happens when joining a world after it loads to 100%

This is an issue with 1.21.4 and will be resolved once this pr is updated for that.
Here is a release, ported for 1.21.4, rendering issues should be fixed and mixin as well. https://github.com/crazymoose7/meteor-rejects/releases/tag/1.21.4

Awesome! I will be looking at SkeletonESP today to see whats going on there. It's actually just one line that I commented out that I need to figure out what it does. The module itself actually seems to work fine.

I had removed the commented line after I believe it is not needed any more perhaps ? I had looked at examples of changes in some of minecrafts own Entities and the changes you made already seemed to be suitable. Let me know what you see !

After some digging, yeah, that line seems useless in SkeletonESP. This means that that module is now fixed and works okay.

There are still some things in Rendering that haven't been ported right? I will start working on those soon. LMK if you find anything relating to that.

crazymoose7 · 2025-01-16T01:14:28Z

@Xtendera I believed Rendering to be all set, what seems to be missing ? I can take another look later.

crosby-moe · 2025-01-21T00:01:22Z

any updates on the state of this pull request?

crazymoose7 · 2025-01-21T00:25:31Z

any updates on the state of this pull request?

I believe it is done ! Have been using the build on my end without issues or any bugs.

Xtendera · 2025-01-21T01:30:43Z

Sorry I was a bit busy. We are good to merge!

crosby-moe · 2025-01-21T02:25:55Z

Sorry I was a bit busy. We are good to merge!

are the SkeletonESP and Rendering modules still broken?

crazymoose7 · 2025-01-21T02:29:44Z

Sorry I was a bit busy. We are good to merge!

are the SkeletonESP and Rendering modules still broken?

Nope ! They work

crosby-moe · 2025-01-21T17:16:09Z

ideally i’d want SkeletonESP to use meteor 3d rendering methods but considering those dont support matrices i guess it can wait

sbxte · 2025-01-25T00:35:59Z

ideally i’d want SkeletonESP to use meteor 3d rendering methods but considering those dont support matrices i guess it can wait

Was just about to ask about that. Everything else looks good and this doesn't seem like too big of an issue so for now I'll glance over it.

[no ci] * Update to 1.21.3/1.21.4 (#399) * Update to 1.21.3 part 1 Don't expect it to work anytime soon. * Update to 1.21.3 part 2 * Gradle 8.8 -> 8.12 * Working Build 1.21.3 Had to revert gradle to 8.10 due to unforseen issues. * Removed Unused Imports * Small rendering fixes (hopefully) * 1.21.4 port * Use Utils.canUpdate in AutoCraft * Intellij code fixes --------- Co-authored-by: crazymoose77756 <ryanrogo064@gmail.com> Co-authored-by: SByte <stormybytes@gmail.com> * github-actions(deps): bump actions/checkout from 3 to 4 (#288) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SByte <stormybytes@gmail.com> * github-actions(deps): bump actions/setup-java from 3.10.0 to 3.13.0 (#289) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.10.0 to 3.13.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3.10.0...v3.13.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SByte <stormybytes@gmail.com> * Bumping Seedfinding Library Version to fix SimOre outdating issue (#376) * Update build.gradle for seedfinding lib --------- Co-authored-by: SByte <stormybytes@gmail.com> * Update version displayed on build workflow * github-actions(deps): bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashray Shah <geektraindev@gmail.com> Co-authored-by: crazymoose77756 <ryanrogo064@gmail.com> Co-authored-by: SByte <stormybytes@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Azote | 窒垝 <azoteg@gmx.com>

* Update to 1.21.3 part 1 Don't expect it to work anytime soon. * Update to 1.21.3 part 2 * Gradle 8.8 -> 8.12 * Working Build 1.21.3 Had to revert gradle to 8.10 due to unforseen issues. * Removed Unused Imports * Small rendering fixes (hopefully) * 1.21.4 port * Use Utils.canUpdate in AutoCraft * Intellij code fixes --------- Co-authored-by: crazymoose77756 <ryanrogo064@gmail.com> Co-authored-by: SByte <stormybytes@gmail.com>

…ope#408) [no ci] * Update to 1.21.3/1.21.4 (AntiCope#399) * Update to 1.21.3 part 1 Don't expect it to work anytime soon. * Update to 1.21.3 part 2 * Gradle 8.8 -> 8.12 * Working Build 1.21.3 Had to revert gradle to 8.10 due to unforseen issues. * Removed Unused Imports * Small rendering fixes (hopefully) * 1.21.4 port * Use Utils.canUpdate in AutoCraft * Intellij code fixes --------- Co-authored-by: crazymoose77756 <ryanrogo064@gmail.com> Co-authored-by: SByte <stormybytes@gmail.com> * github-actions(deps): bump actions/checkout from 3 to 4 (AntiCope#288) Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SByte <stormybytes@gmail.com> * github-actions(deps): bump actions/setup-java from 3.10.0 to 3.13.0 (AntiCope#289) Bumps [actions/setup-java](https://github.com/actions/setup-java) from 3.10.0 to 3.13.0. - [Release notes](https://github.com/actions/setup-java/releases) - [Commits](actions/setup-java@v3.10.0...v3.13.0) --- updated-dependencies: - dependency-name: actions/setup-java dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: SByte <stormybytes@gmail.com> * Bumping Seedfinding Library Version to fix SimOre outdating issue (AntiCope#376) * Update build.gradle for seedfinding lib --------- Co-authored-by: SByte <stormybytes@gmail.com> * Update version displayed on build workflow * github-actions(deps): bump actions/upload-artifact from 3 to 4 Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Ashray Shah <geektraindev@gmail.com> Co-authored-by: crazymoose77756 <ryanrogo064@gmail.com> Co-authored-by: SByte <stormybytes@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Azote | 窒垝 <azoteg@gmx.com>

Xtendera added 2 commits December 21, 2024 23:16

Update to 1.21.3 part 1

7d4f44a

Don't expect it to work anytime soon.

Update to 1.21.3 part 2

5d6f837

Xtendera added 2 commits December 22, 2024 00:51

Gradle 8.8 -> 8.12

b0a0f2b

Working Build 1.21.3

d62a0d7

Had to revert gradle to 8.10 due to unforseen issues.

Removed Unused Imports

63ddbef

ml3czus mentioned this pull request Jan 12, 2025

[Suggestion] Update Pls To 1.21.3 #404

Closed

Xtendera changed the title ~~Update to 1.21.3~~ Update to 1.21.3/1.21.4 Jan 13, 2025

Small rendering fixes (hopefully)

54ef528

crazymoose7 and others added 2 commits January 14, 2025 15:45

1.21.4 port

2dea577

Merge pull request #1 from crazymoose7/1.21.3-port

8c7c94e

Small rendering fixes (hopefully)

Merge branch 'master' into master

91a1c13

Xtendera marked this pull request as ready for review January 21, 2025 01:30

sbxte added 2 commits January 25, 2025 06:30

Use Utils.canUpdate in AutoCraft

2eae630

Intellij code fixes

72387fe

sbxte merged commit 0dcf1a2 into AntiCope:master Jan 25, 2025

sbxte mentioned this pull request Jan 25, 2025

Update to 1.21.1 #384

Closed

5 tasks

Uh oh!

Uh oh!

Conversation

Xtendera commented Dec 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Builds

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Roadmap (Not all changes may be committed yet, this is specifically for my own tracking)

⚠️ Issues with SkeletonESP and Shaders

Uh oh!

Xtendera commented Dec 22, 2024

Uh oh!

ml3czus commented Dec 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xtendera commented Dec 22, 2024

Uh oh!

ml3czus commented Dec 22, 2024

Uh oh!

crazymoose7 commented Dec 25, 2024

Uh oh!

ml3czus commented Dec 25, 2024

Uh oh!

Xtendera commented Dec 26, 2024

Uh oh!

Xtendera commented Dec 30, 2024

Uh oh!

crazymoose7 commented Dec 30, 2024

Uh oh!

vanvac commented Jan 9, 2025

Uh oh!

Xtendera commented Jan 9, 2025

Uh oh!

areume669 commented Jan 13, 2025

Uh oh!

vanvac commented Jan 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fortune428 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazymoose7 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vanvac commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

crazymoose7 commented Jan 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Xtendera commented Jan 15, 2025

Uh oh!

crazymoose7 commented Jan 15, 2025

Uh oh!

Xtendera commented Jan 16, 2025

Uh oh!

crazymoose7 commented Jan 16, 2025

Uh oh!

crosby-moe commented Jan 21, 2025

Uh oh!

crazymoose7 commented Jan 21, 2025

Uh oh!

Xtendera commented Jan 21, 2025

Uh oh!

crosby-moe commented Jan 21, 2025

Uh oh!

crazymoose7 commented Jan 21, 2025

Uh oh!

crosby-moe commented Jan 21, 2025

Uh oh!

sbxte commented Jan 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Xtendera commented Dec 22, 2024 •

edited

Loading

ml3czus commented Dec 22, 2024 •

edited

Loading

vanvac commented Jan 13, 2025 •

edited

Loading

fortune428 commented Jan 14, 2025 •

edited

Loading

crazymoose7 commented Jan 14, 2025 •

edited

Loading

vanvac commented Jan 14, 2025 •

edited

Loading

crazymoose7 commented Jan 14, 2025 •

edited

Loading