Skip to content

Conversation

@JasonP01
Copy link
Contributor

Made logic @unitcap global variable, this allows processors to access their team's unitcap amount.

Begon the awful current ucap counting methods

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@JasonP01
Copy link
Contributor Author

The one in LAssembler might be useless. And the bundle might need better wording. Id rather leave the bundle to the merger

@Anuken
Copy link
Owner

Anuken commented Apr 20, 2025

This is very inefficient. I will not accept a solution that injects a variable into the processor and uses getVar to dynamically update it every frame for every processor. Retaining an instance to the underlying LAssembler is also unacceptable.

@JasonP01
Copy link
Contributor Author

JasonP01 commented Apr 21, 2025

Mightve overreacted. But point remains the same. I can not solve the issue, i spent 6 hours trying and could not.

If you (anuke) wont accept the current state or fix it yourself you can freely deny this pr.

I wont try and fix the issues you stated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants