Skip to content

Publish with esphome stable for core pcm5122#27

Merged
bharvey88 merged 1 commit into
ApolloAutomation:betafrom
bharvey88:fw/publish-esphome-stable
Jun 18, 2026
Merged

Publish with esphome stable for core pcm5122#27
bharvey88 merged 1 commit into
ApolloAutomation:betafrom
bharvey88:fw/publish-esphome-stable

Conversation

@bharvey88

@bharvey88 bharvey88 commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Version: 26.6.17.1

What does this implement/fix?

Reverts the publish workflow's esphome-version pin (2026.5.3) back to stable (now 2026.6.0).

Context: the 2026.5.3 pin keeps the current sonocotta-based firmware building, because that external component breaks on esphome 2026.6 (cv.only_with_esp_idf was removed). The core pcm5122 migration requires 2026.6.0, so the publish must use stable again.

Pairs with the pcm5122 migration PR — merge this one first. On its own this changes no YAML, so it doesn't trigger a firmware rebuild; it just sets the publish version so the migration publishes correctly.

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Build workflow now uses the latest stable ESPHome release instead of a pinned version.

The core pcm5122 component requires esphome 2026.6.0 and fails on
2026.5.3, so the publish build must use 2026.6.0. Revert the
esphome-version pin (2026.5.3) back to stable, which is now 2026.6.0.
This pairs with the pcm5122 migration: the prior sonocotta firmware
needed the 2026.5.3 pin because it breaks on 2026.6.0; the core
component is the fix.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

The esphome-version input in .github/workflows/build.yml is changed from a pinned release (2026.5.3) to the rolling stable channel, causing future builds to use whatever the current stable ESPHome release is.

Changes

ESPHome Version Pin Update

Layer / File(s) Summary
ESPHome version input set to stable
.github/workflows/build.yml
The esphome-version input is updated from the fixed value 2026.5.3 to stable, switching the build to track the rolling stable channel.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • ApolloAutomation/CAST-1#25: Directly inverse change — that PR pinned esphome-version to 2026.5.3 in the same workflow input that this PR reverts back to stable.

Suggested labels

bugfix

Poem

🐇 A version once pinned, now free to roam,
Stable it tracks, wherever builds go,
No more hard numbers etched in stone,
The workflow hops forward, channel unknown,
This bunny approves — let stable lead home! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: updating the publish workflow to use esphome stable version instead of a pinned version for the core pcm5122 component.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@bharvey88

Copy link
Copy Markdown
Contributor Author

Pairs with the pcm5122 migration: #28 — merge this (#27) first so the migration publishes on esphome 2026.6.0.

@bharvey88 bharvey88 merged commit 2c2571e into ApolloAutomation:beta Jun 18, 2026
2 of 9 checks passed
@bharvey88 bharvey88 mentioned this pull request Jun 18, 2026
10 tasks
@bharvey88

Copy link
Copy Markdown
Contributor Author

Migration PR is now #29 (re-opened from the Apollo repo branch). Merge this (#27) first.

@coderabbitai coderabbitai Bot mentioned this pull request Jul 7, 2026
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant