Skip to content

Update Firmware Select - #60

Merged
TrevorSchirmer merged 1 commit into
betafrom
firmware_select
Jul 27, 2026
Merged

Update Firmware Select#60
TrevorSchirmer merged 1 commit into
betafrom
firmware_select

Conversation

@TrevorSchirmer

@TrevorSchirmer TrevorSchirmer commented Jul 27, 2026

Copy link
Copy Markdown
Member

Version: 26.7.27.1

What does this implement/fix?

  • Remove the beta-channel folder

Types of changes

  • Bugfix (fixed change that fixes an issue)
  • New feature (thanks!)
  • Breaking change (repair/feature that breaks existing functionality)
  • Dependency Update - Does not publish
  • Other - Does not publish
  • Website of github readme file update - Does not publish
  • Github workflows - Does not publish

Checklist / Checklijst:

  • The code change has been tested and works locally
  • The code change has not yet been tested

If user-visible functionality or configuration variables are added/modified:

  • Added/updated documentation for the web page

Summary by CodeRabbit

  • Improvements
    • Updated the firmware version to 26.7.27.1.
    • Improved firmware channel selection with Stable as the default option.
    • Updated beta firmware builds to use the latest shared device configurations.
  • Bug Fixes
    • Resolved configuration inconsistencies affecting beta firmware generation.

@github-actions github-actions Bot added the bugfix Something isn't working label Jul 27, 2026
@github-actions
github-actions Bot requested a review from bharvey88 July 27, 2026 17:31
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

CAST-1 ESPHome versioning and firmware channel initialization were updated. The beta build workflow now uses the primary W and ETH configuration files instead of beta-channel overrides, which were removed.

Changes

CAST-1 beta configuration

Layer / File(s) Summary
ESPHome version and channel defaults
Integrations/ESPHome/Core.yaml
Updates the version from 26.7.22.1 to 26.7.27.1 and sets the firmware channel selector’s initial option to Stable.
Beta build configuration inputs
.github/workflows/build-beta.yml
Points CAST-1 W and ETH beta matrix entries to the primary ESPHome configuration files while preserving output names.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested reviewers: bharvey88

Poem

I’m a bunny with builds in a row,
Stable channels now gently glow.
W and ETH paths align,
A newer version hops online.
Beta firmware, ready to go!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and matches the main change: updating firmware selection and related beta-channel configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch firmware_select

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@Integrations/ESPHome/Core.yaml`:
- Line 257: The shared firmware_channel configuration in
Integrations/ESPHome/Core.yaml must retain Stable for production while allowing
the build to override it. Update .github/workflows/build-beta.yml at lines 40-41
to pass or select a Beta-specific channel configuration for beta-fw artifacts;
make the corresponding Core.yaml change so production remains Stable and fresh
beta images target Beta manifests.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bea22e93-0c09-4bd0-aed6-7d4fe9c98857

📥 Commits

Reviewing files that changed from the base of the PR and between 4c8a6bf and e1aa89a.

📒 Files selected for processing (4)
  • .github/workflows/build-beta.yml
  • Integrations/ESPHome/Core.yaml
  • Integrations/ESPHome/beta-channel/CAST-1_ETH.yaml
  • Integrations/ESPHome/beta-channel/CAST-1_W.yaml
💤 Files with no reviewable changes (2)
  • Integrations/ESPHome/beta-channel/CAST-1_W.yaml
  • Integrations/ESPHome/beta-channel/CAST-1_ETH.yaml

- "Stable"
- "Beta"
initial_option: "${firmware_channel_default}"
initial_option: "Stable"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Beta builds lose their Beta OTA default.

The shared configuration defaults firmware_channel to Stable, while the beta workflow now builds that shared configuration and publishes beta-fw assets. Fresh beta images will consequently target stable manifests unless a beta-specific override is provided.

  • Integrations/ESPHome/Core.yaml#L257-L257: retain the stable default for production, but make the channel build-specific.
  • .github/workflows/build-beta.yml#L40-L41: pass or select a Beta-specific configuration/override for these artifacts.
📍 Affects 2 files
  • Integrations/ESPHome/Core.yaml#L257-L257 (this comment)
  • .github/workflows/build-beta.yml#L40-L41
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Integrations/ESPHome/Core.yaml` at line 257, The shared firmware_channel
configuration in Integrations/ESPHome/Core.yaml must retain Stable for
production while allowing the build to override it. Update
.github/workflows/build-beta.yml at lines 40-41 to pass or select a
Beta-specific channel configuration for beta-fw artifacts; make the
corresponding Core.yaml change so production remains Stable and fresh beta
images target Beta manifests.

@TrevorSchirmer
TrevorSchirmer merged commit 4e80e81 into beta Jul 27, 2026
9 checks passed
@TrevorSchirmer
TrevorSchirmer deleted the firmware_select branch July 27, 2026 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants