Update Firmware Select - #60
Conversation
WalkthroughCAST-1 ESPHome versioning and firmware channel initialization were updated. The beta build workflow now uses the primary W and ETH configuration files instead of beta-channel overrides, which were removed. ChangesCAST-1 beta configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Integrations/ESPHome/Core.yaml`:
- Line 257: The shared firmware_channel configuration in
Integrations/ESPHome/Core.yaml must retain Stable for production while allowing
the build to override it. Update .github/workflows/build-beta.yml at lines 40-41
to pass or select a Beta-specific channel configuration for beta-fw artifacts;
make the corresponding Core.yaml change so production remains Stable and fresh
beta images target Beta manifests.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bea22e93-0c09-4bd0-aed6-7d4fe9c98857
📒 Files selected for processing (4)
.github/workflows/build-beta.ymlIntegrations/ESPHome/Core.yamlIntegrations/ESPHome/beta-channel/CAST-1_ETH.yamlIntegrations/ESPHome/beta-channel/CAST-1_W.yaml
💤 Files with no reviewable changes (2)
- Integrations/ESPHome/beta-channel/CAST-1_W.yaml
- Integrations/ESPHome/beta-channel/CAST-1_ETH.yaml
| - "Stable" | ||
| - "Beta" | ||
| initial_option: "${firmware_channel_default}" | ||
| initial_option: "Stable" |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift
Beta builds lose their Beta OTA default.
The shared configuration defaults firmware_channel to Stable, while the beta workflow now builds that shared configuration and publishes beta-fw assets. Fresh beta images will consequently target stable manifests unless a beta-specific override is provided.
Integrations/ESPHome/Core.yaml#L257-L257: retain the stable default for production, but make the channel build-specific..github/workflows/build-beta.yml#L40-L41: pass or select a Beta-specific configuration/override for these artifacts.
📍 Affects 2 files
Integrations/ESPHome/Core.yaml#L257-L257(this comment).github/workflows/build-beta.yml#L40-L41
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@Integrations/ESPHome/Core.yaml` at line 257, The shared firmware_channel
configuration in Integrations/ESPHome/Core.yaml must retain Stable for
production while allowing the build to override it. Update
.github/workflows/build-beta.yml at lines 40-41 to pass or select a
Beta-specific channel configuration for beta-fw artifacts; make the
corresponding Core.yaml change so production remains Stable and fresh beta
images target Beta manifests.
Version: 26.7.27.1
What does this implement/fix?
Types of changes
Checklist / Checklijst:
If user-visible functionality or configuration variables are added/modified:
Summary by CodeRabbit