Skip to content

Device page polish: single-firmware note placement + two config-viewer nits#15

Merged
bharvey88 merged 2 commits into
mainfrom
fix/firmware-note-placement
Jul 10, 2026
Merged

Device page polish: single-firmware note placement + two config-viewer nits#15
bharvey88 merged 2 commits into
mainfrom
fix/firmware-note-placement

Conversation

@bharvey88

Copy link
Copy Markdown
Collaborator

What does this change?

Small device-page polish, all in step 1 / the config viewer:

Note placement — the "One firmware for this device — nothing to choose here." note rendered at the bottom of step 1, below "What's new" and the "Build or reflash" section, which read as confusing. It now sits directly under the picker, where a variant/channel toggle would otherwise appear. Pinned with a test so it can't drift back.

Two nits from the #3 review:

  • downloadText uses the registered application/yaml MIME type instead of the non-registered text/yaml (the download filename is unaffected either way).
  • The test's blobFromRaw helper now falls back to the raw URL on a non-match (mirroring the app's rawToBlob), so a future off-pattern config URL fails as a clean assertion instead of throwing on a null match.

Checklist

  • Playwright tests pass locally (cd tests && npx playwright test) (19 passed, 1 intentional skip)
  • Any new runtime file/dir is added to the cp list in .github/workflows/pages.yml (n/a: edits only, no new files)
  • No new build step, framework, or runtime CDN dependency
  • If devices.json changed: python scripts/validate_registry.py passes (devices.json unchanged)

🤖 Generated with Claude Code

bharvey88 added 2 commits July 9, 2026 18:04
The "One firmware for this device — nothing to choose here." note rendered at
the bottom of step 1, below the release notes and the reflash-config section,
which read as confusing. Move it directly under the picker, where a variant or
channel toggle would otherwise appear, and pin the ordering with a test.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
- downloadText uses the registered application/yaml MIME type instead of the
  non-registered text/yaml (the download filename is unaffected either way).
- The test's blobFromRaw helper now falls back to the raw URL on a non-match,
  mirroring the app's rawToBlob, so a future off-pattern config URL fails as a
  clean assertion instead of throwing on a null match.

🤖 Generated with [Claude Code](https://claude.com/claude-code)
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@bharvey88, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 66f97bb6-f37f-4e36-8fb8-a76ae6527df4

📥 Commits

Reviewing files that changed from the base of the PR and between da5e4c9 and 365cd3c.

📒 Files selected for processing (2)
  • js/views/device.js
  • tests/installer.spec.js
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/firmware-note-placement

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bharvey88 bharvey88 merged commit e663da2 into main Jul 10, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant