Fix bug with previous enhancement#128
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous code changes I made to Multiview added some features, but unfortunately broke double-click method of opening guide files
Code has been reworked so that all methods of opening work properly.
Also updated datatypes.library to stop annoying alert, due to OpenCount error.
The root cause of the OpenCount error is not known, but we do nothing with the counter anyway, so the complaining was worse than the issue it was advising upon.
The above error triggered in Multiview when DisposeDTObject() is called, to free the memory allocated by NewDTObject().
Any new debug messages will not appear unless source is recompiled with #define DEBUG 1 (which I have commented out)
Also, these debug messages can be seen via tools such as Sashimi.
The main features of this change are similar to original - we have numerous new options to set font name, fantasize, window dimensions. These can be set either command line, Multiview icon tool types, or the document icon tool types.